Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response codes > 300 are treated as failed #281

Closed
rdpeake opened this issue May 26, 2016 · 2 comments
Closed

Response codes > 300 are treated as failed #281

rdpeake opened this issue May 26, 2016 · 2 comments

Comments

@rdpeake
Copy link

rdpeake commented May 26, 2016

Our server returns lots of "304 not modified", however this library only flags responses between 200 and 300 as success.

Is there an intention behind this choice?
@adriaanthomas
Copy link

Same problem here.

Looking at the code it suggests this is intentional, but it looks strange to me. Why not do a telemetry.setSuccess(response.getStatus() < 400)?

@jgogstad jgogstad mentioned this issue Jul 27, 2016
Merged
@OriYosefiMSFT
Copy link
Member

will consider response codes >=400 (with the exception of 401) as failures. Anything under is considered success,

@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adriaanthomas @rdpeake @OriYosefiMSFT