Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in dependency graph, core marks agent in provided scope but can't run without it #303

Closed
jgogstad opened this issue Aug 8, 2016 · 2 comments

Comments

@jgogstad
Copy link
Contributor

jgogstad commented Aug 8, 2016

Module Core marks module Agent in provided scope in build.gradle, but depends explicitly on StringUtils which is found in Agent in TelemetryConfigurationFactory. Results in runtime exceptions unless Agent is on classpath. This was introduced by the processors support PR.

Maybe move StringUtil out of the agent module?

@jgogstad
Copy link
Contributor Author

jgogstad commented Aug 9, 2016

On closer inspection I see that you already depend on org.apache.commons:commons-lang3 which provides org.apache.commons.lang3.StringUtils#isBlank. I suggest you use that instead.

@gupele
Copy link
Contributor

gupele commented Aug 25, 2016

Thanks @jgogstad, great catch :)

I am posting a PR with fixes, the fix will use the Core's internal LocalStringsUtils. As a rule of thumb we try avoiding 3rd party use, as much as possible, and this one is very easy to avoid

@gupele gupele closed this as completed in 6b11ba0 Aug 25, 2016
@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants