[Question] Why relocate logback packages and configuration files

[yiliuTo]

I see the code in ai.shadow-conventions.gradle.kts relocates all loback related packages and configs. So I am confused what is the purpose of relocation and isolation of logback? IMO, since logback is imported in agent-tooling with all of its dependencies being loaded in the agent classloader, it won't bring conflicts with users' application or other agent dependencies.

ApplicationInsights-Java/buildSrc/src/main/kotlin/ai.shadow-conventions.gradle.kts

Lines 38 to 47 in 16a727a

	val shadowPrefix = "com.microsoft.applicationinsights.agent.shadow"
	relocate("ch.qos.logback", "$shadowPrefix.ch.qos.logback")
	relocate("javax.annotation", "$shadowPrefix.javax.annotation")
	// to prevent accidentally picking up from user's class path
	relocate("logback.configurationFile", "applicationinsights.logback.configurationFile")
	relocate("logback.xml", "applicationinsights.logback.xml")
	relocate("logback.groovy", "applicationinsights.logback.groovy")
	relocate("logback-test.xml", "applicationinsights.logback-test.xml")

[trask]

hi @yiliuTo! I believe that you're right and relocation is no longer needed after #3190 (logback was originally in the bootstrap class loader which is why shading was needed before)

[yiliuTo]

Thanks @trask for the explanation.