Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class "javax.annotation.Nullable"'s signer information does not match signer information of other classes in the same package #362

Closed
maciek-prokopiuk opened this issue Feb 9, 2017 · 14 comments
Assignees
Labels
Milestone

Comments

@maciek-prokopiuk
Copy link

There is javax.annotation package inlined in applicationinsight-core.jar (v 1.0.7). Unfortunately whole jar is signed so it force us to use classes from the same package. While, for example, Nullable class is included in both JDK and applicationinsights-core we are getting class "javax.annotation.Nullable"'s signer information does not match signer information of other classes in the same package. Are there any known solutions for dealing with such issue?

Possible solution could be to exclude javax.annotation package from the JAR and use one included in JDK.

@jwoehrle
Copy link

I can confirm this issue. For the time being I switched back to version 1.0.6. This version does not contain the dependency to JSR-305.

@ghost
Copy link

ghost commented Feb 20, 2017

can confirm, we are also facing this issue. we will switch back to 1.0.6

@Dmitry-Matveev Dmitry-Matveev added this to the 1.0.8 milestone Feb 21, 2017
@Dmitry-Matveev
Copy link
Member

Thank you for reporting this! This should be addressed as part of 1.0.8 release.

@tomaszglinski
Copy link

I have the same problem. I suppose the may happen will all of other dependencies copied into jar, like org.objectsweb.asm, but javax is the most common blocker.

When is some new release going to be rolled out?

@debugthings
Copy link
Contributor

#367 Related

@beckylino beckylino modified the milestones: 1.0.9, 1.0.8, 1.0.10 Jun 13, 2017
@beckylino
Copy link

beckylino commented Aug 2, 2017

@maciek-prokopiuk, @tomaszglinski, @jwoehrle, and @dimonok were any of you able to upgrade to the 1.0.8 version of our SDK? Is this issue still persisting? Thanks :)

@beckylino beckylino modified the milestones: future, 1.0.10 Aug 2, 2017
@maciek-prokopiuk
Copy link
Author

Unfortunately I am not working on this project anymore and do not have access to the codebase. Maybe other guys can check it. Good luck ;)

@tomaszglinski
Copy link

I will try it when I get some free time :)

@jwoehrle
Copy link

jwoehrle commented Aug 3, 2017

puh, I don't remember how to reproduce this issue... Did it happen at compile or at runtime?

@maciek-prokopiuk
Copy link
Author

@jwoehrle it was SecurityException which is Runtime one. At compile time you do not know which jar will be used as it could be provided for example.

@dhaval24
Copy link
Contributor

@maciek-prokopiuk it seems that we are repackaging the javax.annotation dependency in the code using shadow jar in the latest 1.0.10 version of the SDK. were you able to try this with latest SDK? If issue no longer persist feel free to close the issue on github

@maciek-prokopiuk
Copy link
Author

@dhaval24 sorry I have no longer access to the codebase that uses Insights. maybe someone else can check that as I will have no possibilities to do that soon

@dhaval24
Copy link
Contributor

@maciek-prokopiuk thanks for letting me know. I will keep the thread open for few more days to see if anyone else is facing the same issue before closing it.

@littleaj littleaj self-assigned this Jan 9, 2018
@littleaj
Copy link
Contributor

littleaj commented Feb 7, 2018

Verified the javax.annotation is no longer included inside the AI jars.

@littleaj littleaj closed this as completed Feb 7, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

8 participants