Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding Microsoft.ApplicationInsights.AspNetCore as a dependency in 2.1-based package #13

Closed
jeremymeng opened this issue Jun 21, 2018 · 1 comment
Closed

Consider adding Microsoft.ApplicationInsights.AspNetCore as a dependency in 2.1-based package #13

jeremymeng opened this issue Jun 21, 2018 · 1 comment
Assignees
@xiaomi7732
Labels
bug Something isn't working fix available Fix is checked into source control, ready to be released
Milestone
1.1.3-beta1

Comments

@jeremymeng
Copy link
Member

In ASP.NET Core 2.1, the default project template does not pull in the Microsoft.ApplicationInsights.AspNetCore so I had to add it in order for the newer 2.1-based profiler package to work. It is better to specify it as a dependency so end users don't need to include it by themselves.
@xiaomi7732 xiaomi7732 added the bug Something isn't working label Jun 21, 2018
@xiaomi7732 xiaomi7732 self-assigned this Jun 26, 2018
@xiaomi7732 xiaomi7732 added the status: investigating Issue in investigating, fix not available yet. label Jun 26, 2018
@xiaomi7732 xiaomi7732 added fix available Fix is checked into source control, ready to be released and removed status: investigating Issue in investigating, fix not available yet. labels Jul 5, 2018
@xiaomi7732 xiaomi7732 added this to the 1.1.3-beta1 milestone Jul 5, 2018
@xiaomi7732
Copy link
Member

https://www.nuget.org/packages/Microsoft.ApplicationInsights.Profiler.AspNetCore/1.1.3-beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiaomi7732 xiaomi7732

Labels
bug Something isn't working fix available Fix is checked into source control, ready to be released
Projects
None yet
Milestone
1.1.3-beta1
Development

No branches or pull requests
2 participants
@xiaomi7732 @jeremymeng