Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installcredprovider scripts should allow to pass in a version #88

Closed
ViktorHofer opened this issue Apr 4, 2019 · 3 comments · Fixed by #130
Closed

installcredprovider scripts should allow to pass in a version #88

ViktorHofer opened this issue Apr 4, 2019 · 3 comments · Fixed by #130
Labels
enhancement New feature or request

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Apr 4, 2019 •
edited
Loading

Passing in a version explictly instead of relying on latest is important for deterministic builds.
@ViktorHofer ViktorHofer mentioned this issue Apr 4, 2019
Merged
@satbai satbai added the enhancement New feature or request label May 8, 2019
@satbai satbai mentioned this issue Jul 12, 2019
Merged
@satbai satbai closed this as completed Jul 15, 2019
@satbai satbai reopened this Jul 15, 2019
@satbai
Copy link
Contributor

satbai commented Jul 15, 2019

Reopening the issue since my PR only added the enhancement to the .ps1 script, but not the .sh script.

@lukeschlather
Copy link

Would it be possible to package this installation via nuget?

@satbai satbai mentioned this issue Nov 27, 2019
Merged
@satbai
Copy link
Contributor

satbai commented Nov 28, 2019 •
edited
Loading

Had to revert the PR, here's the new one: #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improving install scripts microsoft/artifacts-credprovider
3 participants
@lukeschlather @ViktorHofer @satbai