Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Update Dockerfiles to use COPY instruction rather than ADD #72

Closed
MichaelSimons opened this issue Nov 27, 2017 · 4 comments
Closed

Update Dockerfiles to use COPY instruction rather than ADD #72

MichaelSimons opened this issue Nov 27, 2017 · 4 comments
Assignees
@HongGit

Comments

@MichaelSimons
Copy link
Member

To conform with Dockerfile best practices, the COPY instruction is preferred over ADD. All Microsoft Dockerfiles should be following the best practices as they are often referred upon and copied.

Related to microsoft/dotnet-framework-docker#45
@shirhatti shirhatti mentioned this issue Nov 27, 2017
Closed
@HongGit HongGit self-assigned this Nov 30, 2017
@HongGit
Copy link
Member

HongGit commented Jan 13, 2018

I have scanned all DockerFiles, and find that all COPY commands are replaced with ADD.

@HongGit HongGit closed this as completed Jan 13, 2018
@MichaelSimons
Copy link
Member Author

@HongGit - not sure I understand your comment. The recommendation is to use COPY, not ADD.

@MichaelSimons MichaelSimons reopened this Jan 13, 2018
@HongGit
Copy link
Member

HongGit commented Jan 13, 2018

@MichaelSimons my bad. I will fix that.

@HongGit HongGit mentioned this issue Jan 17, 2018
Merged
@HongGit
Copy link
Member

HongGit commented Jan 18, 2018

This has been fixed in PR#85.

@HongGit HongGit closed this as completed Jan 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HongGit HongGit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelSimons @HongGit