Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify tool functions and user defined functions #2101

Open
Tracked by #1421
jackgerrits opened this issue Mar 20, 2024 · 3 comments
Open
Tracked by #1421

Unify tool functions and user defined functions #2101

jackgerrits opened this issue Mar 20, 2024 · 3 comments
Labels
code-execution execute generated code enhancement New feature or request function/tool suggestion and execution of function/tool call

Comments

@jackgerrits
Copy link
Member

Currently, tool functions and user defined functions in executors behave fairly differently. We would like to unify the behavior and usage of these so that they are easier to understand and use.

More details to come in this issue.

@jackgerrits jackgerrits added enhancement New feature or request code-execution execute generated code function/tool suggestion and execution of function/tool call labels Mar 20, 2024
@krishnashed
Copy link
Collaborator

Hi @jackgerrits I see this github issue is still open and unassigned. I was notified about this issue while working on #1510 by Linxin Song. Can I contribute to this issue ?

@ekzhu
Copy link
Collaborator

ekzhu commented Apr 17, 2024

@jackgerrits is there some advice you can give to @krishnashed regarding this issue?

@jackgerrits
Copy link
Member Author

We need to come up with a plan and design on how to unify them. One option is to add function execution to the code executor interface, another option is to add a FunctionExecutor interface that follows a similar input format to udfs in code executors so they feel consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-execution execute generated code enhancement New feature or request function/tool suggestion and execution of function/tool call
Projects
None yet
Development

No branches or pull requests

3 participants