Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Change status of LandmarkOneMain to warning #165

Closed
karanbirsingh opened this issue Oct 14, 2019 · 1 comment
Closed

[BUG] Change status of LandmarkOneMain to warning #165

karanbirsingh opened this issue Oct 14, 2019 · 1 comment
Labels
bug Something isn't working status: resolved This issue has been merged into main.

Comments

@karanbirsingh
Copy link
Contributor

karanbirsingh commented Oct 14, 2019

Describe the bug

The LandmarkOneMain rule checks if a page has a single main landmark (no more, no less). This maps to best-practice / moderate user impact in a similar rule in axe-core. The intent is that websites shown in browsers or WebViews should have a main landmark to ease navigation. Our rule can pick up a case where a WebView is used in a larger XAML application to show a small portion of a webpage, even if the app has a XAML main landmark of its own. Determining whether a main landmark is appropriate in these different cases should be done manually and is more of an assessment-type of test. The LandmarkOneMain rule should be changed to 'warning' to reflect this.

axe-windows version 0.3.4

@ghost ghost added the status: new This issue is new and requires triage by DRI. label Oct 14, 2019
@ghost ghost assigned karanbirsingh Oct 14, 2019
@karanbirsingh karanbirsingh added the status: ready for work This issue is ready to be worked on. label Oct 14, 2019
@ghost ghost removed the status: new This issue is new and requires triage by DRI. label Oct 14, 2019
@karanbirsingh karanbirsingh removed their assignment Oct 17, 2019
@ferBonnin ferBonnin added the bug Something isn't working label Oct 21, 2019
@karanbirsingh
Copy link
Contributor Author

closing as LandmarkOneMain already is classified as a 'warning' instead of an 'error'. I am unable to reproduce this now, so it's likely I confused an outdated result with a current one when filing the issue

@karanbirsingh karanbirsingh added the status: resolved This issue has been merged into main. label Oct 22, 2019
@ghost ghost removed the status: ready for work This issue is ready to be worked on. label Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status: resolved This issue has been merged into main.
Projects
None yet
Development

No branches or pull requests

2 participants