Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Dapr 1.12 #1003

Open
jsheetzmt opened this issue Nov 22, 2023 · 12 comments
Open

Feature Request: Dapr 1.12 #1003

jsheetzmt opened this issue Nov 22, 2023 · 12 comments
Assignees
Labels
enhancement New feature or request

Comments

@jsheetzmt
Copy link

What is the ETA for Dapr 1.12? 1.12 fixes a memory leak when doing service-to-service invocation through the gRPC proxy.

dapr/dapr#6734

@jsheetzmt jsheetzmt added the enhancement New feature or request label Nov 22, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: triage 🔍 Pending a first pass to read, tag, and assign label Nov 22, 2023
@berndverst
Copy link
Member

berndverst commented Nov 22, 2023

Dapr maintainer and Azure Container Apps engineer here. As you can tell by the 1.12.1 and 1.12.2 patch releases in the dapr/dapr repo there were quite a few things that needed to be fixed in the 1.12.0 release as well.

We are looking into ways to give customers more control over the Dapr version they are running. But until then, we are conservative about version upgrades. I think it's fair to say that the 1.12.2 release is finally looking more stable - so there is a good chance we'll be bringing that version to Container Apps in the near future.

Any critical 1.11.X issues receive patch releases, and we are very fast to update Container Apps to patch releases of the same minor version.
To my knowledge, there is no memory leak in 1.11.X with regards to service invocation that is unpatched. Instead, in 1.12.X there are memory optimizations due to use of streaming - which doesn't require the sidecar to temporarily load objects completely into memory. If this were not intended behavior we'd have a 1.11.X patch release for it in OSS :)

Thanks for your patience while we work to ensure the stability of the 1.12.X upgrade.

@jsheetzmt
Copy link
Author

Thanks for the additional information and looking forward to more Dapr control! The connection/memory leak was identified against 1.11 and not sure if it was backported into a 1.11.x release. Verified the connection leak is gone when using the 1.12 sidecar locally.

@greenie-msft
Copy link
Collaborator

We're currently targeting early January 2024 for the availability of Dapr 1.12 in ACA.

@greenie-msft greenie-msft removed the Needs: triage 🔍 Pending a first pass to read, tag, and assign label Nov 29, 2023
@berndverst
Copy link
Member

@jsheetzmt I just read through the issue dapr/dapr#6734 - there the Dapr Runtime maintainers decided that this issue is not a leak / bug, but rather some unoptimized code which was improved in 1.12.

If you feel that this is a bug / leak then I suggest opening an issue in https://github.com/dapr/dapr/ to ask for this fix to be applied in 1.11 as well (the runtime maintainers will need to decide on this). 1.10 and 1.11 are still supported releases - so should receive patch releases for issues.

Once this gets included in a 1.11.X release in Dapr we can bring this change very quickly to ACA.

@lewis-hu
Copy link

lewis-hu commented Jan 30, 2024

We're currently targeting early January 2024 for the availability of Dapr 1.12 in ACA.

@greenie-msft

Is there an update to this please?

@berndverst
Copy link
Member

We're currently targeting early January 2024 for the availability of Dapr 1.12 in ACA.

@greenie-msft

Is there an update to this please?

We have been working on this with utmost priority. Because of significant internal architectural changes in Dapr 1.12 this version upgrade has been especially difficult to bring to Container Apps.

We are currently finalizing a release candidate and will perform our own internal testing. Once we are satisfied with our testing we will then get this rolled out in ACA.

It will be based on Dapr 1.12.4.

@dandoj
Copy link

dandoj commented Mar 1, 2024

hi, any update here - we are waiting for this update

@berndverst
Copy link
Member

Several people on my team have been working on this. We ran into a compatibility problem with Dapr 1.12 during the release process. We have since addressed this and are currently in the final testing phase before attempting another rollout of Dapr 1.12. I currently expect the release to occur within the next 2-3 weeks, unless other technical challenges are encountered.

1.12.5 will now be the base image. It also upgrades the Azure SDKs to the latest releases (newer than what is available in Dapr OSS 1.12.5 or even 1.13.0)

@jsheetzmt
Copy link
Author

@berndverst Any update on Dapr 1.12 rollout?

@berndverst
Copy link
Member

berndverst commented Apr 1, 2024

We are currently waiting for the next internal platform feature release to be rolled out. This will include Dapr 1.12. I do not have an exact timeline unfortunately. I will provide an update here as soon as I learn of the deployment date. Hopefully soon 🤞.

@lewis-hu
Copy link

fyi I see 1.12.5 in our env already

@berndverst
Copy link
Member

fyi I see 1.12.5 in our env already

@lewis-hu - that's correct. Dapr 1.12.5 was rolled out as part of the updates for Microsoft Build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants