Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to set Request Size (Dapr: --http-max-request-size flag) #116

Closed
XavierGeerinck opened this issue Feb 18, 2022 · 15 comments
Closed
Assignees
Labels
roadmap This feature is on the roadmap

Comments

@XavierGeerinck
Copy link

Is there a way to set the --http-max-request-size flag? I got an app and am sadly enough triggering the body too large error

@kendallroden kendallroden added the investigating currently looking into the issue label Feb 23, 2022
@kendallroden
Copy link
Contributor

We are investigating and will report back

@kendallroden kendallroden added the enhancement New feature or request label Apr 12, 2022
@kendallroden kendallroden added this to Requested Enhancements in Feature Requests Apr 21, 2022
@sergiibielskyi
Copy link

Hey. Any updates on it?

@sergiibielskyi
Copy link

I think it would be great to add this option/parameter as annotation to dapr settings
dapr: {
enabled: true
appPort: 80
appId: 'daprapp'
http-max-request-size: 16
}

@XavierGeerinck
Copy link
Author

Any update on this? I am missing it as well for a production app (always receiving ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer')) now)

@XavierGeerinck
Copy link
Author

This is what I am seeing, which is preventing my production workload from working correctly :( sadly enough I can't compress images below 4 Mb

image

@kendallroden any update?

@lewismartin512
Copy link

Any updates? We are blocked from moving forward until this flag becomes available.

@sahibble
Copy link

This feature is also crucial for me to move forward with container apps. The 4MB limit is very restricting.

@kendallroden
Copy link
Contributor

Thanks for letting us know I am checking with engineering

@dale-personal
Copy link

dale-personal commented Sep 21, 2022

Any updates?

It seems that this gives the appearance of being supported via cli (https://learn.microsoft.com/en-us/cli/azure/containerapp/dapr?view=azure-cli-latest#az-containerapp-dapr-enable):

az containerapp dapr enable --dapr-http-max-request-size 32

when i run this command the output seems to indicate success:

{
"appId": "api",
"appPort": 80,
"appProtocol": "http",
"enableApiLogging": false,
"enabled": true,
"httpMaxRequestSize": 32,
"logLevel": "info"
}

However, these values are not in the azure portal (see attachment).

Also, when i look at the JSON for the container app overview in the portal, I only see:

"dapr": {
"enabled": true,
"appId": "api",
"appProtocol": "http",
"appPort": 80
}

I will add that the dapr error for this is not properly surfaced in the logs.

Container apps log the following error:
System.Net.Http.HttpRequestException: An error occurred while sending the request.
2022-09-21T12:26:38.938415931Z ---> System.IO.IOException: The response ended prematurely.

while debugging locally, i see the more helpful dapr error:
Dapr.DaprApiException: error invoke actor method: body size exceeds the given limit

dapr-azure-portal

@sergiibielskyi
Copy link

it works if you change the extension by using the command like this one
az containerapp dapr enable -n containerapp -g "$NAME_RG" --dapr-app-id daprId --dapr-http-max-request-size 16

@dale-personal
Copy link

That essentially is the command i am running:
az containerapp dapr enable -n $name -g $resourceGroup --dapr-app-id api --dapr-app-port 80 --dapr-app-protocol http --dapr-http-max-request-size 32

It shows up in the json settings if you change the API version to 2022-06-01-preview but it does not have an effect on the container - I still receive the error message with requests larger than 4MB.

Presumably because this is in the API preview and not actually implemented in the deployed containers yet?

@sergiibielskyi
Copy link

that works if you use the right template (not a preview one). Just tested on my container apps.

@dale-personal
Copy link

Can you elaborate a bit on what you mean by "right template"?

Here is what i am using:
resource api 'Microsoft.App/containerApps@2022-03-01' = { ...

This is not working (for me at least). perhaps i will try setting this to @2022-06-01-preview and see if that works.

@kendallroden
Copy link
Contributor

The feature is rolling out across CLI and portal hence why they are not in line yet

@kendallroden kendallroden added roadmap This feature is on the roadmap and removed investigating currently looking into the issue enhancement New feature or request labels Sep 27, 2022
@kendallroden
Copy link
Contributor

closing due to availability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
roadmap This feature is on the roadmap
Projects
No open projects
Feature Requests
Requested Enhancements
Development

No branches or pull requests

7 participants