Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample instructions should not create a secret in source code #66

Open
johnterickson opened this issue Feb 13, 2021 · 1 comment
Open
Assignees

Comments

@johnterickson
Copy link

johnterickson commented Feb 13, 2021

I followed the instructions here and was surprised that the CLIENT_SECRET was not only written to disk in plain text, but was written to the source code directory in a file that is already tracked by source code.

@CatherineOsadciw
Copy link
Contributor

That code is pulled directly from the Azure portal quickstart for generating a sample web app using MSAL. The full public documentation that has not yet been released for this API specifically includes a warning that this should not be done in production code & offers 2 alternatives, which matches the messaging in the Azure portal when generating a quickstart app.

I could either add the same messaging directly to the README here, allowing the user to choose whatever alternative to secret management is best for them, or diverge from the Azure quickstart default and adjust the code to use an environment variable (currently suggested in the config file comments for all quickstart apps, including this one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants