Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getCommitsBatch doesn't return remoteUrl when using only ids #86

Closed
jabbera opened this issue Mar 14, 2017 · 2 comments
Closed

getCommitsBatch doesn't return remoteUrl when using only ids #86

jabbera opened this issue Mar 14, 2017 · 2 comments
Assignees

Comments

@jabbera
Copy link

jabbera commented Mar 14, 2017

The little says it all.

let blah: giti.GitQueryCommitsCriteria = { ids = ["A", "B"] } as git.GitQueryCommitsCriteria
await api.getCommitsBatch(blah, restofargs)

no remoteurl returned:-(

@stephenmichaelf stephenmichaelf self-assigned this Feb 13, 2018
@stephenmichaelf
Copy link
Member

@jabbera I tried to recreate the issue with the latest on master (6.3.0-preview) and the code is working as expected for me. Here is what I did:

const gitApi: IGitApi = await vsts.getGitApi();
const commitCriteria: GitQueryCommitsCriteria = { ids: ["a---8", "6---b"] } as GitQueryCommitsCriteria;
const respositoryId: string = "b---b";
const commitsBatch: GitCommitRef[] = await gitApi.getCommitsBatch(commitCriteria, respositoryId);

if (commitsBatch) {
    for (var commitBatch of commitsBatch) {
        console.log("url: " + commitBatch.url);
    }
}

Are you still having this issue? If so could you add some more details. Thanks!

@stephenmichaelf
Copy link
Member

Closing since this seems to be working, please reopen and add additional details if you are still having issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants