Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tool runner should call chcp.com 65001 on Windows #139

Closed
ericsciple opened this issue Sep 8, 2016 · 3 comments
Closed

Tool runner should call chcp.com 65001 on Windows #139

ericsciple opened this issue Sep 8, 2016 · 3 comments
Assignees
@ericsciple @dakale
Labels
documentation

Comments

@ericsciple
Copy link
Contributor

Nice to have
@ericsciple ericsciple self-assigned this Sep 8, 2016
@ericsciple
Copy link
Contributor Author

The hesitations that I have about this are: It doesn't fix some tools, and I'm not sure how high of a percent that it does fix. It makes the shell weird for anyone manually testing (not e2e, but calling script directly). For instances it breaks more.com.

More importantly than doing something that may not work (and likely cause confusion), I'm thinking this would be good to cover in a document about invoking tools. Even if we added chcp.com to be called automatically, it feels like we would need a doc to explain. So I'm thinking a doc is a good place to start either way.

@ericsciple
Copy link
Contributor Author

And it causes csc.exe to crash when chcp is 65001! (was causing unit tests in this repo to fail for me)

@ericsciple
Copy link
Contributor Author

@dakale fyi - since this was implemented differently (in the agent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericsciple ericsciple

@dakale dakale

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericsciple @dakale