Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function App deployment should default to webdeploy #6759

Closed
paulbatum opened this issue Mar 21, 2018 · 5 comments
Closed

Function App deployment should default to webdeploy #6759

paulbatum opened this issue Mar 21, 2018 · 5 comments
Assignees
Labels
Area: AzureAppService Label to monitor Azure App Service issues Area: Release enhancement

Comments

@paulbatum
Copy link

Hi there, I work on Azure Functions. I would like to propose that when a user selects an app type of Function App, webdeploy should be the default deployment method.

image

The main reason for this is that zip based deployment does not put a consumption function app into a consistent state. An action is required to "sync triggers", and if this is not done then the app will not scale properly. When deploying through webdeploy, this step happens automatically.

See here for an example of a customer running into this issue:
Azure/azure-functions-host#2499 (comment)

Bonus points for:

  1. If the user opts out of webdeploy, ideally the task would manually call sync triggers. This would be useful in cases where the agent is linux based and webdeploy cannot be used. This action is documented here. Here is a quick example of the sync triggers action being called:
    https://github.com/davidebbo/AzureWebsitesSamples/blob/61c7b330e83750cd4092625d082340d69f3a54ec/PowerShell/HelperFunctions.ps1#L362-L367
  2. Defaulting to Remove additional files at destination to enabled. This way, if a user deletes the code for a function from their function app which is deployed through this task, the function will actually be deleted, which is probably what they intended.
@davidebbo
Copy link

I know there is a lot of confusion around this, but the best thing you should be using is the zipdeploy API.

As for Consumption Linux, it doesn't support any of those (zip, zipdeploy, WebDeploy), so we'll need to come up with alternative (mostly a different discussion).

@paulbatum
Copy link
Author

David just explained this to me, and I now agree with him. I think instead of making webdeploy the default, it would make more sense for the "zip" based default to use the "zipdeploy" API he linked.

@kmkumaran @vincentdass is there already a issue tracking switching over to the "zipdeploy" API? If so we can probably close this..

@RoopeshNair
Copy link
Member

zipdeploy support is in progress.

@Ruud-cb
Copy link

Ruud-cb commented Nov 6, 2020

I come here from Azure/azure-functions-host#2697 where I am a bit confused if I should use zipdeploy or webdeploy now? It has already been 2 years ago but currently still experiencing issues that are described in the referenced issue.

@kdubau
Copy link
Member

kdubau commented Nov 17, 2020

Agreed with @Ruud-cb .. still having this issue and the documentation is unclear.

@kmkumaran kmkumaran assigned chshrikh, N-Usha and nadesu and unassigned kmkumaran and vincent1173 Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: AzureAppService Label to monitor Azure App Service issues Area: Release enhancement
Projects
None yet
Development

No branches or pull requests