-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timeoutInMinutes is number or string? #411
Comments
@dynamicwebpaige @sethjuarez can you help us clarify whether timeoutInMinutes should be a string or a number? There seems to be a contradiction in the documentation |
@Borda As I see documentation has a correct type for this variable, it should be a number. |
@Borda Do you have any additional questions regarding azure-pipelines-vscode extension itself? |
not really just these types for checking... Thx |
In this way, I am closing this ticket. |
@EzzhevNikita do you say that the string instead or a number is correct? here you have string, but docs say a number... |
@EzzhevNikita so you say that the correct is number in form of a string? I feel quite confused... |
@Borda There is no number type in the schema at all, if you will take a look all numbers are represented as nonEmptyString. |
I was running check for JSON and found some confusion as schema say
timeoutInMinutes
shall be a string:https://raw.githubusercontent.com/microsoft/azure-pipelines-vscode/v1.188.1/service-schema.json
On the other hand, docs say number:
https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema%2Cparameter-schema#job
you can find the failing over here: https://github.com/PyTorchLightning/pytorch-lightning/pull/8567/checks?check_run_id=3170968920#step:5:6
The text was updated successfully, but these errors were encountered: