Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeoutInMinutes is number or string? #411

Closed
Borda opened this issue Jul 27, 2021 · 8 comments
Closed

timeoutInMinutes is number or string? #411

Borda opened this issue Jul 27, 2021 · 8 comments
Assignees
Labels
Area: VsCodeExtension question Further information is requested

Comments

@Borda
Copy link

Borda commented Jul 27, 2021

I was running check for JSON and found some confusion as schema say timeoutInMinutes shall be a string:
https://raw.githubusercontent.com/microsoft/azure-pipelines-vscode/v1.188.1/service-schema.json
On the other hand, docs say number:
https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema%2Cparameter-schema#job
you can find the failing over here: https://github.com/PyTorchLightning/pytorch-lightning/pull/8567/checks?check_run_id=3170968920#step:5:6

@aribornstein
Copy link

aribornstein commented Jul 27, 2021

@dynamicwebpaige @sethjuarez can you help us clarify whether timeoutInMinutes should be a string or a number? There seems to be a contradiction in the documentation

@EzzhevNikita EzzhevNikita added question Further information is requested and removed triage labels Jul 27, 2021
@EzzhevNikita
Copy link

@Borda As I see documentation has a correct type for this variable, it should be a number.

@EzzhevNikita
Copy link

@Borda Do you have any additional questions regarding azure-pipelines-vscode extension itself?

@Borda
Copy link
Author

Borda commented Jul 29, 2021

Do you have any additional questions regarding azure-pipelines-vscode extension itself?

not really just these types for checking... Thx

@EzzhevNikita
Copy link

Do you have any additional questions regarding azure-pipelines-vscode extension itself?

not really just these types for checking... Thx

In this way, I am closing this ticket.

@Borda
Copy link
Author

Borda commented Jul 29, 2021

In this way, I am closing this ticket.

@EzzhevNikita do you say that the string instead or a number is correct? here you have string, but docs say a number...

@Borda
Copy link
Author

Borda commented Aug 1, 2021

As I see documentation has a correct type for this variable, it should be a number.

@EzzhevNikita so you say that the correct is number in form of a string? I feel quite confused...

@EzzhevNikita
Copy link

@Borda There is no number type in the schema at all, if you will take a look all numbers are represented as nonEmptyString.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: VsCodeExtension question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants