Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOM should not provide dependency management for third party libraries #128

Closed
snicoll opened this issue Aug 28, 2017 · 1 comment · Fixed by #138
Closed

BOM should not provide dependency management for third party libraries #128

snicoll opened this issue Aug 28, 2017 · 1 comment · Fixed by #138
Assignees

Comments

@snicoll
Copy link
Contributor

snicoll commented Aug 28, 2017

It looks like you attempted to do something similar to spring-boot-dependencies which is the BOM of a "platform" (with stronger semantics). This project is more narrowed and its bom should only expose dependency management for the artifacts that the project produces (so in this case, azure artifacts). It should not have an opinion about third party dependencies (otherwise including that BOM in a project potentially overrides decisions that were made about them)

For versions that match the version of the project (everything in an ideal world except maybe Microsoft-specific jars that the starters require), I'd set them explicitly rather than using ${bom.version}. If you're including the bom for Azure X.Y.Z, it should be X.Y.Z. and nothing else (Maven does not allow to override that property, which is good so it's not strictly necessary but the intent is more clear if you hardcode the current version).

Here is an example of BOM for reference: http://repo.spring.io/release/org/springframework/spring-framework-bom/4.3.8.RELEASE/spring-framework-bom-4.3.8.RELEASE.pom

@ZhijunZhao
Copy link
Contributor

@snicoll Stéphane, thanks for all the valuable feedbacks. I'll resolve all of them ASAP. Then, I'll release them with a new version and update the Initializr PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants