Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Azure ChatGPT is responsive for mobile devices #92

Closed
Zenulous opened this issue Aug 10, 2023 · 6 comments
Closed

Ensure Azure ChatGPT is responsive for mobile devices #92

Zenulous opened this issue Aug 10, 2023 · 6 comments

Comments

@Zenulous
Copy link

Zenulous commented Aug 10, 2023

I'm sure the team is aware of this: the current sample is not responsive on mobile at all.

Image

I understand that this is a starter repo and that the focus is more on providing a private solution with a Cosmos data store. However, making the UI work well on different devices is a bit of a no-brainer to me. Thanks for the consideration.

@oliverlabs oliverlabs mentioned this issue Aug 12, 2023
@giuliohome
Copy link

giuliohome commented Aug 14, 2023

Done a similar change in my copy in src/features/chat/chat-menu/chat-menu.tsx

'use client'
import { FC, useState } from 'react';

....
interface Prop {
 items : Array<ChatThreadModel>
}


const ChatMenu : FC<Prop>= async (prop) => {
  
  const [isOpen, setIsOpen] = useState(false);
  
  return (

        <div><button onClick={() => setIsOpen(!isOpen)}>
          {isOpen ? '-' : '+'}
        </button>
   {isOpen ? <Menu  >
      <MenuHeader className="justify-end">
       
....

And changed also src/app/chat/layout.tsx

const DynChatMenu = dynamic(() => import('@/features/chat/chat-menu/chat-menu'), { ssr: false });

...

export default async function RootLayout({
  children,
}: {
  children: React.ReactNode;
}) {
  const items : ChatThreadModel[] = await FindAllChatThreadForCurrentUser();
  
  return (
    <ProtectedPage>
      <MainMenu />
      <DynChatMenu items={items} />
      <div className="flex-1">{children}</div>
    </ProtectedPage>
  );
}

@giuliohome
Copy link

giuliohome commented Aug 14, 2023

Screenshot_2023-08-14-09-18-08-325_com android chrome

Screenshot_2023-08-14-09-25-32-351_com android chrome

@oliverlabs
Copy link
Contributor

@giuliohome, that's great. Which branch in your repo has this changes? I couldn't find it. Could you submit a PR or post full code? The snippets are difficult to interpret.

@giuliohome
Copy link

Sorry did all that from my mobile, used a private github and codespaces while on holiday to my azure subscription. Will post my PR if needed for sure, no worries, but here the developers are better than me at UI design of course!

@thivy
Copy link
Contributor

thivy commented Aug 15, 2023

Added this to the backlog item

@thivy thivy closed this as completed Aug 15, 2023
@oliverlabs
Copy link
Contributor

any updates on this? @thivy

QDAP-Fred referenced this issue in QDAP-DATAAI/qchat Mar 27, 2024
Added extra helpers and audio error handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants