Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open folder doesn't work on new window. #22022

Open
octaviordz opened this issue Feb 24, 2023 · 7 comments
Open

Open folder doesn't work on new window. #22022

octaviordz opened this issue Feb 24, 2023 · 7 comments

Comments

@octaviordz
Copy link

Issue Type: Bug

When opening a new window and trying to open a folder in the new window it doesn't work no error is display but the folder is not display either. It's like vscode freezes trying to open the folder in the new window.
image

Azure Data Studio version: azuredatastudio-insiders 1.42.0-insider (c5fc37c, 2023-02-17T06:29:22.173Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No
Preview Features: Enabled

System Info
Item Value
CPUs 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz (8 x 2995)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
Load (avg) undefined
Memory (System) 15.69GB (0.79GB free)
Process Argv --ms-enable-electron-run-as-node .
Screen Reader no
VM 0%
Extensions: none
@caohai
Copy link
Member

caohai commented Feb 24, 2023

@octaviordz Thanks for reporting this! I can confirm the repro with both insiders build and official build.
image

Version: 1.41.2
Commit: 0f0960d0e774e1ce903b79378addff96117c27a6
Date: 2023-02-08T20:15:24.215Z
VS Code: 1.67.0
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin x64 21.6.0

@octaviordz
Copy link
Author

Thank for your response @caohai. I have been seeing this behavior for a while now. As I recall it started as sometimes it would work and other times it won't but now it pretty much fails every time.
The work around that I have been using is in a console/terminal go to the folder and run "azuredatastudio ." . Hope this helps.

@kburtram kburtram self-assigned this Feb 27, 2023
@kburtram kburtram added this to the March 2023 Release milestone Feb 27, 2023
@kburtram
Copy link
Member

It looks like in some cases the workbench files are loading prior to running the sql/setup.js loader. This causing all the model-view UI components to pull in angular prior to reflect-metadata loading. I'll look for a way to get reflect-metadata loaded early in the bootstrap sequence.

bootstrap-window.js:259 [uncaught exception]: reflect-metadata shim is required when using class decorators
b	@	bootstrap-window.js:259
(anonymous)	@	bootstrap-window.js:52
emit	@	node:events:526
window.onerror	@	node:electron/js2c/renderer_init:73
error (async)		
(anonymous)	@	node:electron/js2c/renderer_init:73
./lib/renderer/init.ts	@	node:electron/js2c/renderer_init:73
__webpack_require__	@	node:electron/js2c/renderer_init:1
(anonymous)	@	node:electron/js2c/renderer_init:1
___electron_webpack_init__	@	node:electron/js2c/renderer_init:1
(anonymous)	@	node:electron/js2c/renderer_init:141
compileForInternalLoader	@	node:internal/bootstrap/loaders:312
compileForPublicLoader	@	node:internal/bootstrap/loaders:252
loadNativeModule	@	node:internal/modules/cjs/helpers:49
Module._load	@	node:internal/modules/cjs/loader:811
c._load	@	node:electron/js2c/asar_bundle:5
executeUserEntryPoint	@	node:internal/modules/run_main:77
(anonymous)	@	node:internal/main/run_main_module:17

@michelmetran
Copy link

While the problem is not resolved, I chose to add a key to the Windows registry, allowing me to open Azure Data Studio in a more practical way. View issue #22225 .

@GridTrekkor
Copy link

GridTrekkor commented Apr 3, 2024

Here's the workaround I use for this issue:

  • open new window from existing window (I use Ctrl+Shift+N)
  • open devtools by clicking Help > Toggle Developer Tools
  • now open the folder within ADS

Not sure if related, but I occasionally see these errors

GET vscode-file://vscode-app/c:/Program%20Files/Azure%20Data%20Studio/resources/app/out/vs/code/electron-sandbox/workbench/css/common.css net::ERR_FILE_NOT_FOUND

WARN Via 'product.json#extensionEnabledApiProposals' extension 'github.copilot-chat' wants API proposal 'semanticSimilarity' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.

ERR Extension 'github.copilot' appears in product.json but enables LESS API proposals than the extension wants. package.json (LOSES): inlineCompletionsAdditions, terminalDataWriteEvent product.json (WINS): inlineCompletionsAdditions

@GridTrekkor
Copy link

Update to above: seems my workaround is no longer working for me.

I'm on Windows 10, but others reported it on Windows 11.

@GridTrekkor
Copy link

GridTrekkor commented Apr 30, 2024

It worked once for me today, then not again. I'm getting the same console error as above:

Uncaught reflect-metadata shim is required when using class decorators

DecoratorFactory @ decorators.ts:300

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants