Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop showing copy notification #24009

Closed
mtaylorfsmb opened this issue Jul 28, 2023 · 18 comments
Closed

Stop showing copy notification #24009

mtaylorfsmb opened this issue Jul 28, 2023 · 18 comments
Assignees
Labels
Area - Query Editor Enhancement Request for new features or functionality Size: S For a small complexity issue - only when fixed with a PR Triage: Done

Comments

@mtaylorfsmb
Copy link

mtaylorfsmb commented Jul 28, 2023

Type: Feature Request

I don't remember seeing this behavior before but starting with 1.45.0 every time I copy data from the query results window I get a notification in the lower right of the window saying the data was copied with a Close option. I want to disable this option. The reason I don't like it is:

  1. It shows up to 3 notifications that honestly provide no real value over a simple notification in the status bar or equivalent.
  2. The notifications don't go away so you have to close the message even though it is just a notification.
  3. Even though you only see 3 notifications on the screen, it appears that the others are still there because if you had, say 5, notifications then you have to close all 5 even though you only see 3 at a time.

I would like to request the following:

  1. Make the notification a toast that automatically goes away after a few seconds. This is pretty standard for "non-critical" notifications.
  2. Give me an option to not show this notification at all.

Azure Data Studio version: azuredatastudio 1.45.0 (8eff468, 2023-07-24T18:22:12.106Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No
Preview Features: Disabled
Modes:

@chris-tietgen
Copy link

Tbh, I don't mind the notification as most of the time prior to this release the copy wouldn't even work using CTRL+C. At least now I will know. Hopefully copying has been fixed in general.

I agree with your two suggestions, though.

@rolovargas
Copy link

Please please please provide the option to disable this notification!
It's so unnecessary.
I don't know of any other app that shows this kind of notification for a Copy.

@cheenamalhotra cheenamalhotra added Enhancement Request for new features or functionality and removed Bug labels Jul 31, 2023
@cheenamalhotra cheenamalhotra added this to the September 2023 Release milestone Jul 31, 2023
@DrMarkX
Copy link

DrMarkX commented Jul 31, 2023

I agree, either have a toggle to turn off or a timeout setting on the notifications show they do not continue to stack.

@stahler
Copy link

stahler commented Jul 31, 2023

Agree with the requests. Doesn't add value, detracts from a workflow and takes up precious space on a small screen.
image

@dubeg
Copy link

dubeg commented Aug 1, 2023

I wonder what prompted the team to add this "feature".

@cg-tm
Copy link

cg-tm commented Aug 1, 2023

I wonder what prompted the team to add this "feature".

My guess is a long-standing issue where data wouldn't copy to the clipboard immediately. For whatever reason data studio had to 'process' that for even basic stuff like a single cell.

That's a lot better now so this popup/notification progress (similar to save as CSV/Excel) is now the confirmation the copy is 'done'

@stahler
Copy link

stahler commented Aug 1, 2023

If you have three notifications you have to click on them multiple times to close.

@cg-tm
Copy link

cg-tm commented Aug 1, 2023

Yup, seems like they already fixed it for the dev build though (either can turn it off entirely and when on it'll disappear after 3 seconds)

#24037

So hopefully part of insiders/full production soon!

@cheenamalhotra
Copy link
Member

cheenamalhotra commented Aug 1, 2023

Yes indeed. The fix is now merged in main:

  • Notifications will auto-close in 3 seconds (when they show up)
  • You will have an option to disable them completely with below setting:
    image

This support will be available in the September release (v1.46+).

@cheenamalhotra
Copy link
Member

Will proceed to close this issue as fix is now available in the latest insiders build.
Thanks!

@PaulSpoerry
Copy link

I hate this so much I'm tempted to just install the insiders build just to not have to see it!

@barrygrow
Copy link

I too hate this so much, I am installing the Insiders Build 1.46.0!

@jagdishrajan
Copy link

While I prefer to stay with the main release I have to move to the insider's build because of how disruptive this feature is. It's amazing that such a pointless feature implemented without a setting to turn it off has been so disruptive.

@jkmuka
Copy link

jkmuka commented Sep 14, 2023

I hope future iterations will think through the UX more. Productivity and efficiency are some of what I believe many of us are seeking in ADS and this popup runs counter to that. Even if you try to ignore it and leave the 3 notifications, the top one is constantly refreshed whenever a new copy operation is performed. Our eyes are continuously scanning the results area for meaningful errors, results, server name, warnings, etc. This copy notification is a huge distraction and steals attention in even the most menial of tasks.

@anthonylevine
Copy link

I know this is closed, but I cannot express how frustrating it is to have to close pop-up notifications each time I hit Control + C.
image

@Charles-Gagnon
Copy link
Contributor

Charles-Gagnon commented Sep 22, 2023

If you update to the latest version we've added the ability to disable this notification. Thank you for your feedback everyone!

@anthonylevine
Copy link

Thank you.

@markjpT markjpT mentioned this issue Sep 23, 2023
@richardtallent-erm
Copy link

While removing the pop-up is nice, can anyone tell me where we're tracking the issue that selecting a single cell and hitting Ctrl-C does not IMMEDIATELY push that data into my clipboard? Why is it taking 3-5 seconds to update the clipboard?

I could understand if I was trying to copy and paste thousands of records, which may not be loaded into the grid, but for copying text from a few rows and columns that are directly viewable on my screen should take milliseconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area - Query Editor Enhancement Request for new features or functionality Size: S For a small complexity issue - only when fixed with a PR Triage: Done
Projects
Development

No branches or pull requests