Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y_Azure Data Studio Nov2023_Files_Add Database File_VoiceOver: Name is not defined descriptively for Path section "More Option" button. #25157

Closed
Mana-swi opened this issue Jan 2, 2024 · 4 comments
Assignees
Labels
A11y_BasicAdminDialogs Used for tracking accessibility issues for the Basic Admin dialogs Area - Basic Admin Bug Impact: Accessibility Issues that impact accessibility compliance Pri: 2 Triage: Done

Comments

@Mana-swi
Copy link

Mana-swi commented Jan 2, 2024

Please do not close this bug. This bug should only be closed by Trusted Tester after verification.
Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.

GitHub Tags:

#A11yTCS; #A11yMAS; #A11ySev2; #DesktopApp; #WCAG4.1.2; #NameRoleValue; #FTP; #SH_Azure Data Studio_Nov2023_Mac_Dec2023; #SQL Azure Data Studio; #MAC; #VoiceOver;

Environment Details:

Application Name: Azure Data Studio
Operating System: macOS Sonoma 14.2.1
Azure data studio 1.47.0
VoiceOver

Repro Steps:

  1. Install Azure data studio application and open it
  2. Make sure to enable "Preview" feature in settings.
  3. Turn on voiceover.
  4. Tab till "Database" and press ENTER to expand the tree.
  5. Tab till any database and pressF10 to open context menu.
  6. Tab till "Properties Preview" and press ENTER.
  7. Tab till "Files" tab and press ENTER.
  8. Tab till "Database files" table and press ENTER to select the row.
  9. Tab till "Add" button and press ENTER.
  10. "Add Database File" dialog will appear.
  11. Tab till " more option" button in Path Section.
  12. You will observe that voice over is announcing as "..., button" for more option button.

Actual Result:

Voice over is announcing as "..., button" for more option button present in "Path" section of "Add Database File" dialog.

Note: Similar issue is observed for Edit Database File ->Path section "More Option" button.

Expected Result:

Voice over should announce as "Path More option button" for button present in "Path" section of "Add Database File" dialog. The name for "more option" button should be described clearly to understand the purpose of control.

User Impact:

Screen Reader users will face difficulties to understand the purpose of the button if name is not descriptive enough.

Attachment:

Name is not descripyive for More option button

@Mana-swi Mana-swi changed the title A11y_Azure Data Studio_Nov2023_Files_Add Database File_VoiceOver: Name is not defined descriptively for Path section "More Option" button. A11y_Azure Data Studio Nov2023_Files_Add Database File_VoiceOver: Name is not defined descriptively for Path section "More Option" button. Jan 2, 2024
@kisantia kisantia added Impact: Accessibility Issues that impact accessibility compliance Triage: Needed Area - Basic Admin Bug labels Jan 2, 2024
@corivera corivera self-assigned this Jan 8, 2024
@corivera corivera added A11y_BasicAdminDialogs Used for tracking accessibility issues for the Basic Admin dialogs Triage: Done and removed Triage: Needed labels Jan 8, 2024
@corivera corivera added this to the February 2024 Release milestone Jan 16, 2024
@corivera corivera assigned barbaravaldez and unassigned corivera Jan 17, 2024
@barbaravaldez
Copy link
Contributor

Fixed by #25233

@corivera
Copy link
Member

@Mana-swi The issue has been fixed in the latest Mac Insiders build of ADS here. Can you verify that the issue is resolved?

@Mana-swi
Copy link
Author

Mana-swi commented Feb 5, 2024

#Regressed:02-05-24; Reopened;

Hi @corivera
Verified the issue in below environment
Azure data Studio Version: 1.47.1 (Universal)
VS Code: 1.82.0
Electron: 25.8.4
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 23.2.0

The issue is still repro'ing, please find below attachment for reference. Thanks!

25157_Name is not defined descriptively for Path section More Option button

@Mana-swi
Copy link
Author

Mana-swi commented Feb 6, 2024

#Regressed:02-06-24; #Closed;

Verified the issue in below environment
Version: 1.48.0-insider (Universal)
VS Code: 1.82.0
Electron: 25.9.8
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 23.2.0
MacOS: sonoma 14.2.1

The issue is fixed, hence closing the bug. Please find attachment for reference. Thanks!

Browse file button

@Mana-swi Mana-swi closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y_BasicAdminDialogs Used for tracking accessibility issues for the Basic Admin dialogs Area - Basic Admin Bug Impact: Accessibility Issues that impact accessibility compliance Pri: 2 Triage: Done
Projects
None yet
Development

No branches or pull requests

4 participants