Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the chart viewer throws an error, unexpected behavior occurs. #37

Closed
martinisaksen opened this issue Nov 15, 2017 · 2 comments · Fixed by #1052
Closed

When the chart viewer throws an error, unexpected behavior occurs. #37

martinisaksen opened this issue Nov 15, 2017 · 2 comments · Fixed by #1052

Comments

@martinisaksen
Copy link

  • SQL Operations Studio Version: 0.23.6

Steps to Reproduce:

  1. Run "SELECT 1 AS A"
  2. Select "View as Chart"

What I'd expect to see:
Chart viewer tab selected and count Chart Type selected.

What I see:
Stays at Results tab but Chart Viewer tab is available. I have to manually click on the tab and choose "count".

@kburtram kburtram added the Bug label Nov 16, 2017
@kburtram kburtram added this to the April Public Preview milestone Jan 23, 2018
@anthonydresser anthonydresser changed the title Chart Viewer isn't focused when it doesn't auto detect a chart to use When the chart viewer throws an error, unexpected behavior occurs. Mar 21, 2018
@anthonydresser
Copy link
Contributor

When the chart viewer throws an error a few things can happen.

  1. The tab is not navigated to automatically.
  2. On subsequent re-runs, you can't open the tab all together.

At the end of the day we should properly catch errors that occur do to miss-formatted data and ensure expected behavior still occurs.

@anthonydresser
Copy link
Contributor

Additionally, if on chart type change an error is thrown, it can make the chart unresponsive and require a rerun to make work again.

@adsbot adsbot bot locked and limited conversation to collaborators Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants