Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema compare tasks show default cancel context menu which does nothing #5804

Closed
udeeshagautam opened this issue May 31, 2019 · 2 comments
Closed

Schema compare tasks show default cancel context menu which does nothing #5804

udeeshagautam opened this issue May 31, 2019 · 2 comments
Assignees
@udeeshagautam
Labels
Area - Schema Compare Bug
Milestone
July 2019 Release

Comments

@udeeshagautam
Copy link
Contributor

udeeshagautam commented May 31, 2019 •
edited
Loading

  • Azure Data Studio Version:
    Version: 1.8.0-insider (system setup)
    Commit: d7df71c
    Date: 2019-05-31T14:51:26.886Z
    VS Code 1.34.0
    Electron: 3.1.8
    Chrome: 66.0.3359.181
    Node.js: 10.2.0
    V8: 6.6.346.32
    OS: Windows_NT x64 10.0.17763

Steps to Reproduce:

  1. Schema comapre tasks Generate script and apply get an automatical context menu for cancel
  2. It does nothitng but shows in UX as cancelled
  3. This might get very confusing

image

We need to disable this cancel context menu option.
@udeeshagautam udeeshagautam added this to the June 2019 Release milestone May 31, 2019
@udeeshagautam
Copy link
Contributor Author

@kburtram do you think this qualifies for June?

@udeeshagautam udeeshagautam mentioned this issue May 31, 2019
Closed
@kburtram kburtram modified the milestones: July 2019 Release, Planning Jun 6, 2019
@udeeshagautam udeeshagautam self-assigned this Jun 26, 2019
@udeeshagautam
Copy link
Contributor Author

Fixed by adding actual cancel operation on cancel

@adsbot adsbot bot locked and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@udeeshagautam udeeshagautam

Labels
Area - Schema Compare Bug
Projects
None yet
Milestone
July 2019 Release
Development

No branches or pull requests
2 participants
@kburtram @udeeshagautam