-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database Folder not Expanding #6450
Comments
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like: |
Could you please paste the contents of the original report? Does this happen consistently and is there any error displayed when you try to expand or does it just sit there spinning forever? |
I copied and pasted the entire error message and results in the original post. This problem does happen consistently since I have applied an update from Azure Data Studio. After spinning from some time, it gives the error message "Object Explorer task didn't complete within 45 seconds." I am able to right-click on the database and select Manage and then I instantly get a list of the table and I can do my work from there. This issue seems to be isolated to opening the database folder in the object explorer. |
It would be nice if this bug got more love. We have Azure servers hosting 5000 DBs, and they always time out when trying to open ServerName/Databases in the connections pane. While it can take a bit to populate that data in SSMS, it does eventually come up, and typically in less than 45 seconds. |
@chaibloom which version of ADS are you using? |
@aaomidi - 1.13.0 |
I have this same issue in 1.13.1. Like juniordeveloperbootcamp, if I choose to "Manage" and then refresh the Object Explorer view, I am able to see the tables and views. Otherwise, it times out. Server I'm connecting to is version 14.0.3045.24. |
I get this issue as well from time to time on 1.15.0-insider |
Experiencing this issue at version 1.14.1. Would love to use this product in place of ssms, but this basic feature's incompatibility with azure SQL strikes me as disqualifying. 'Azure' data studio, huh. |
@xspdr1800 - You can reset that by opening the command pallet and running the
Then re-open the dashboard and the widget should appear again. @alanrenmsft @kisantia This is pretty annoying that there doesn't seem to be an easy way to reset the default dashboard widgets - let's make sure we have that be easy with the new Dashboard refactor. |
Also experiencing the expansion timeout with 500 databases on Azure SQL DB. Connection to the server is fine and the dashboard shows the full list of databases alsmost instantaneously. However trying to expand the databases node on Object Explorer results in the 45 seconds timeout. Is the timeout value configurable in the settings anywhere? Version 1.15.1 |
@Charles-Gagnon I could find the original comment provided by @xspdr1800, but I think we can do it by adding a task 'Restore settings' to server and database dashboards, the workflow would be:
I will run this by the team in our next dashboard improvement meeting this week. |
This error still occurs on latest version (1.17). Was already submitted in #3270. As suggested in the other issue, the database listing is instant when using the server details, but fails when using the left pane browser. For just displaying the database nodes, the query you execute could be optimized. It's not really fun to exclude all people using Azure SQL Database with more than a few hundreds database from using your tool. Perhaps at least you could provide a simple way (raw setting) to increase the timeout for this query ? |
Still an issue in 1.19 Changing to using full fat SQL SSMS |
Still occurring on latest version with less than 50 databases on an Azure Sql Database server. Same error: the server browser tries to connect to all databases one after another with a global timeout of 45 seconds. Unsurprisingly, it does not scale well when you have any serious amount of databases. And it works perfectly well when you use the Manage Server pane to list all databases (certainly only using master db to populate this list and restraining itself from doing any operation on each database while enumerating). I am surprised that this issue is not given any attention, since it completely ruins basic Azure Data Studio usage when connecting to Azure Sql Database Server with more than any trivial amount of databases. |
@abist could you please take a look? |
@alanrenmsft I don't think I will be able to work on this for August release, this is a perf issue and a non-trivial task |
From terminal, click output, Log (Window)
|
@hfleitas I think your issue is more along the lines of #12992 Has this also recently just started happening for you? (as in with the latest release) I'm going to leave instructions for some further logs to provide in the linked issue - the issue seems to be in a separate part of the application. So if you could get me those that would be helpful. |
@Charles-Gagnon yes, this is recently occurring for me and my team. I'll send the logs in the linked issue. Thx |
hi @Charles-Gagnon but I cant delete it |
I am experiencing the same thing as referenced in 13836 I have no problem in SSMS expanding Databases and within a database, Tables. But in both ADS 1.27.0 for Mac and Windows 10, clicking on Databases doesn't show anything. However, in both Windows and Mac, in the Connection Details pane, I can choose a database from the Database drop-down. But once I establish a connection to a particular database, I can't see any properties or anything else for that database. On this server, unlike others where I have not experienced this issue, I don't have sysadmin privileges, just public, with db_owner privileges on the individual databases. (These are all on-premise SQL Servers, using integrated authentication from both Mac and Windows) One possible additional clue. I just tried establishing a connection in IntelliJ IDEA to the problematic database server. I am using the Microsoft JDBC Driver 9.2 for SQL Server with integrated authentication. If I specify the database, I can browse only the tables in the dbo. schema (including sysdiagrams), none of the tables in other schemas. |
I am no longer experiencing this issue in ADS 1.28.0. |
This error is still there in the latest version. Please note that in my case it seems to be a performance problem, and not a regression. See #3270 (2018) for the initial report. Azure Data Studio has never been able to browse our Azure SQL Server. See this full reproduction cases for our server. You can observe:
For me there is a N+1 queries problem, where the folder expansion time is relative to the number of databases, or something running for each database in the node list... which is quite problematic. |
I've noticed this only occurs to me if I have a Serverless SQL Azure DB that's asleep. If I refresh it after a couple minutes it works just fine. Why would Serverless DB's be an issue? |
Still having this issue in 2022 with |
@kburtram FYI I've been looking into this and have identified what seems to be the main cause of the issue - SMO is currently attempting to connect to every database when the databases folder is expanded. This can easily cause timeouts on Azure servers with many DB's. We're currently working on addressing that by doing a best attempt to not require connecting to every DB on a server unless a db-specific property is accessed (which ADS isn't doing currently). That should help address the most common timeouts that people are having. There's still an issue that if any of the databases are inaccessible for some reason then SMO will attempt to connect to that database multiple times (retry logic was added for serverless scenarios among other reasons), but if the DB is completely inaccessible then we have to wait for the login attempt to time out which can take 5+seconds for each attempt and thus very quickly go over the 45sec limit. Unfortunately this second one is a lot trickier to solve - we're looking at ways to do that but unfortunately there doesn't seem to be a way that we can do that without breaking other scenarios. The only true way to solve this completely would be to use SFC queries directly (like SSMS does) to populate the list and only when a database node itself is expanded use the full SMO DB object. This would require a bigger refactor of the core OE logic though so I'm planning on getting these SMO changes in and seeing how much of an improvement we're seeing there, and then looking into the refactoring if there's still enough cases of people hitting the timeout issues. |
Interesting insight @Charles-Gagnon. Since you mentioned "many Azure DB's" I wanted to confirm that this issue can be encountered with very few DB's. To add more context -- this issue totally prevented adoption of Azure Data Studio in an environment where I don't recall more than a handful of SQL servers (the company in question was connecting to SQL Server on Windows-powered AWS EC2 instances via VPN). It was a while back now (what an old issue!) but IIRC it was 3. I wanted to offer it over SSMS because it could also connect to a couple Postgres servers and train users on a common client/tool that would (or was at least expected to) play really nice with SQL Server. |
Thanks for the info, I'll be adding more logging too so we can track down exactly what issues are in different cases which should help. You're saying that you were seeing this even with on-prem instances on a VM? That's definitely pretty odd - the investigation I'm doing is centered around Azure since that's where we get the most latency issues since we haven't seen an indication that box/standard SQL instances have these same issues. |
For Azure SQL with 10 DBs I can confirm if a serverless DB is asleep it fails to show the databases in the connections window. If I wake up the database and they all are online it shows the DBs pretty quickly without issue. |
Issue is now fixed with #21475 addressed. |
We have written the needed data into your clipboard because it was too large to send. Please paste:
Issue Type: Performance Issue
With connecting to an Azure SQL Database, the Database folder will not expand. It will always timeout.
Azure Data Studio version: azuredatastudio 1.9.0 (78a42e1, 2019-07-10T04:31:36.998Z)
OS version: Windows_NT x64 10.0.17763
System Info
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Process Info
Workspace Info
The text was updated successfully, but these errors were encountered: