Skip to content
This repository has been archived by the owner on Oct 31, 2019. It is now read-only.

Return TRUE for if function calls are successful, rather than "Done" #31

Closed
gjwgit opened this issue Dec 22, 2016 · 3 comments
Closed

Return TRUE for if function calls are successful, rather than "Done" #31

gjwgit opened this issue Dec 22, 2016 · 3 comments
Labels
question
Milestone
v0.2.3

Comments

@gjwgit
Copy link

gjwgit commented Dec 22, 2016 •
edited by andrie

What does the "R" in the status codes mean? It's not listed.

> azureStopVM(azureActiveContext=sc, resourceGroup=RG, vmName=vmnames[1])
azureStopVM: Request Submitted:  2016-12-22 09:10:37
Updating(U), deallocating(D), starting(S), Stopped/Deallocated(-) 
**R**DDDDDDDDDDDDDDDDDDDD
Finished Deallocated Sucessfully:  2016-12-22 09:12:20
Finished:  2016-12-22 09:12:20
[1] "Done"

Do we need to return "Done"? Just a silent TRUE might be okay. This probably applies across many other of the functions too.

Similarly - what is A in the following:

azureDeployTemplate: Request Submitted:  2016-12-22 11:26:14
Running(R), Succeeded(S)
**A**RRRR
@Alanwe
Copy link
Member

Alanwe commented Dec 22, 2016 •
edited by andrie

Happy to move "Done" to TRUE , however I think we should ensure there is an informational message.

A means accepted, we should add it to the description

@andrie andrie changed the title Status codes and function returns Return TRUE for if function calls are successful, rather than "Done" Feb 6, 2017
@andrie
Copy link
Contributor

andrie commented Feb 13, 2017

I'm slowly working through all the functions to return logical values.

andrie added a commit that referenced this issue Feb 13, 2017
@andrie
Update tests to reflect that function output is TRUE when successful #31
272a79a
andrie added a commit that referenced this issue Feb 13, 2017
@andrie
Merge branch '44-blob-no-authenticate' into dev
83a0507 
* 44-blob-no-authenticate:
  Update tests to reflect that function output is TRUE when successful #31
  Remove redundant arguments, e.g. azToken #50
  Add validateStorageArguments() function #46
  Support downloading more than 5000 blob results, by passing maxresults as an argument #48
  Replace cat() with message() #49
  Modify tests to reflect that azureCheckToken() return logical value
  Modify azurePutBlob() to use callAzureStorageApi() and updateAzureActiveContext() #46
  Add updateAzureActiveContext() function to simplify code #46
  Only attempts to authenticate if is.activeAzureContect() is TRUE #46
  Define callAzureStorageApi() function and use in azureListStorageBlobs() #46
  Don't authenticate - workaround for testing - have to fix this!!! #44
  Allow setting azureContext = NULL to access blob storage.  Edits only to azureListStorageBlobs() and azureGetBlob() #44
  Add Visual Studio RTVS files to .gitignore
andrie added a commit that referenced this issue May 21, 2017
@andrie
Return TRUE for successful completion of functions, rather than statu…
47bba86 
…s message #31
@andrie andrie added this to the v0.2.3 milestone May 21, 2017
@andrie
Copy link
Contributor

andrie commented May 21, 2017

Migration now complete. Closing this issue.

@andrie andrie closed this as completed May 21, 2017
andrie added a commit that referenced this issue May 21, 2017
@andrie
Merge branch 'dev'
d125bfb 
* dev:
  Return TRUE for successful completion of functions, rather than status message #31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
v0.2.3
Development

No branches or pull requests
3 participants
@andrie @gjwgit @Alanwe