Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot Telemetry not correctly instantiated for websocket connection #2474

Closed
lauren-mills opened this issue Sep 4, 2019 · 2 comments · Fixed by #2580
Closed

Bot Telemetry not correctly instantiated for websocket connection #2474

lauren-mills opened this issue Sep 4, 2019 · 2 comments · Fixed by #2580

Comments

@lauren-mills
Copy link
Contributor

lauren-mills commented Sep 4, 2019

Version

What package version of the SDK are you using.
4.5.1

Describe the bug

Give a clear and concise description of what the bug is.
When connecting to a skill over websockets, the telemetry that is logged is missing the ActivityId and ConversationId that are used in Power BI to show dialog metrics. This appears to be because of the dependency on the HttpContext here

@lzc850612 - Please add anything I've missed.

To Reproduce

Steps to reproduce the behavior:

  1. Use VA with skill over websockets
  2. View AppInsights data from conversations using this query:
customEvents
| project 
ActivityId = customDimensions.activityId,
ReplyActivityId = customDimensions.replyActivityId , 
operation_Name = operation_Name ,
ConversationId = session_Id ,
Text = customDimensions.text,
EventName = name, 
Time = timestamp, 
DialogStepName = customDimensions.StepName,
Date = timestamp,
DialogInstanceId = customDimensions.InstanceId,
DialogId = customDimensions.DialogId 
| where EventName startswith "Waterfall"
| order by Time desc
  1. ActivityId and ConversationId are empty

Expected behavior

Give a clear and concise description of what you expected to happen.
ActivityId and ConversationId should be logged for each activity that comes through.

Screenshots

If applicable, add screenshots to help explain your problem.
AppInsights Query Results:
image

Additional context

Add any other context about the problem here.
Related issues:
microsoft/botframework-solutions#2155
microsoft/botframework-solutions#2262

@garypretty
Copy link
Contributor

Tracking PR #2580 which should fix this issue.

@lauren-mills
Copy link
Contributor Author

lauren-mills commented Sep 26, 2019

Confirmed the PR fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants