Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] [LG] optimize inline text evaluation #1712

Closed
tomlm opened this issue Feb 13, 2020 · 0 comments · Fixed by #1752
Closed

[PORT] [LG] optimize inline text evaluation #1712

tomlm opened this issue Feb 13, 2020 · 0 comments · Fixed by #1752
Assignees
Labels
R8 Release 8 - March 16th, 2020
Milestone

Comments

@tomlm
Copy link
Contributor

tomlm commented Feb 13, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#3387

Originally, we do parse the additional inline text directly.

In this pr, we will add a new text parser, that accepts the text and original LGFile both.
So, there will be no intermediate error messages appearing in parse directly.
At the same time, no impact on parse performance.

close: #3352

Changed projects

  • Microsoft.Bot.Builder.LanguageGeneration
  • Microsoft.Bot.Builder.Dialogs.Adaptive.Templates.Tests
  • Microsoft.Bot.Builder.LanguageGeneration.Tests
@Danieladu Danieladu self-assigned this Feb 13, 2020
@vishwacsena vishwacsena added R8 Release 8 - March 16th, 2020 lg labels Feb 18, 2020
@Kaiqb Kaiqb assigned Stevenic and unassigned Stevenic Feb 18, 2020
@munozemilio munozemilio added this to the R8 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R8 Release 8 - March 16th, 2020
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants