Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT] EoC should only be handled when coming from parent in RunAsync #1897

Closed
tomlm opened this issue Mar 12, 2020 · 1 comment · Fixed by #1898
Closed

[PORT] EoC should only be handled when coming from parent in RunAsync #1897

tomlm opened this issue Mar 12, 2020 · 1 comment · Fixed by #1898
Assignees
@stevengum
Labels
P0 Must Fix. Release-blocker R8 Release 8 - March 16th, 2020
Milestone
R8

Comments

@tomlm
Copy link
Contributor

tomlm commented Mar 12, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#3540

Fixes #3541

Added check to only cancel dialogs in RunAsync when EoC comes from a parent bot (root or skill).

The issue was that this affected part of the code was being triggered when a skill responds with an EoC to a caller (EoCs are routed back to the pipeline in SkillHandler).

This PR also applies the urn format to CallerId as per OBI Spec

Changed projects

  • Microsoft.Bot.Builder.Dialogs
  • integration
@gabog gabog added P0 Must Fix. Release-blocker R8 Release 8 - March 16th, 2020 Skills labels Mar 12, 2020
@stevengum stevengum mentioned this issue Mar 12, 2020
Merged
@stevengum stevengum self-assigned this Mar 12, 2020
@stevengum
Copy link
Member

Closing via #1896

@stevengum stevengum mentioned this issue Mar 12, 2020
Merged
@munozemilio munozemilio added this to the R8 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevengum stevengum

Labels
P0 Must Fix. Release-blocker R8 Release 8 - March 16th, 2020
Projects
None yet
Milestone
R8
Development

Successfully merging a pull request may close this issue.

[master, cherry-pick] fix runDialog helper, fix callerId microsoft/botbuilder-js
4 participants
@gabog @stevengum @tomlm @munozemilio