Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchEngine and scoreThreshold should be optional fileds for QnAMakerOptions #70

Closed
anastasiia-zolochevska opened this issue Feb 13, 2018 · 3 comments
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@anastasiia-zolochevska
Copy link

As a workaround we had to cast QnAMakerOptions to type any
const qna = new QnAMaker({
knowledgeBaseId: ‘x',
subscriptionKey: ‘x',
top: 4,
} as any);

@Stevenic
Copy link
Contributor

Good feedback.... I'll make those changes. I'd fixed some issues around that but must have missed QnA maker.

@Stevenic Stevenic self-assigned this Feb 13, 2018
@Stevenic Stevenic added the bug Indicates an unexpected problem or an unintended behavior. label Feb 13, 2018
@cleemullins
Copy link
Contributor

Please be sure to file tracking bugs against the C# version of the QnA Maker stack.
@johnataylor was in there last and would be a good assignee for them.

@Stevenic
Copy link
Contributor

QnA maker has since be re-written and no longer references search engine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Development

No branches or pull requests

3 participants