Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add staging boolean option to LuisRecognizerOptions #88

Closed
3 tasks
mattmazzola opened this issue Feb 19, 2018 · 3 comments
Closed
3 tasks

Add staging boolean option to LuisRecognizerOptions #88

mattmazzola opened this issue Feb 19, 2018 · 3 comments
Assignees

Comments

@mattmazzola
Copy link
Member

From what I see there is no way to configure the LuisRecognizer to use the staging deployment slot.

It needs to construct the url with the staging=true query parameter; however, there no option in LuisRecognizerOptions for staging.

I looked into submitting PR to add the boolean; but the request url is generated inside the LuisClient which is constructed from a swagger file and that needs to understand the staging option.

  • Update botframework-luis swagger to have staging query parameter
  • Regenerate client
  • Add staging: boolean to LuisRecognizerOptions
@stevengum
Copy link
Member

This is actually related to issue #77. The currently used Swagger file is very out of date. I think the plan is to pursue creating a NPM library through the Azure-sdk-for-node with the Azure-approved Swagger file and then in botbuilder-ai create a depedency on that library; similar to what is done in Microsoft.Bot.Builder.Ai for the LuisRecognizerMiddleware class.

@Stevenic
Copy link
Contributor

I was about to make the same comment. The swagger used was out of date. We should get this issue resolved and the LUIS client updated this week.

@Stevenic Stevenic self-assigned this Feb 19, 2018
@Stevenic Stevenic added bug Indicates an unexpected problem or an unintended behavior. enhancement and removed bug Indicates an unexpected problem or an unintended behavior. labels Feb 19, 2018
@Stevenic
Copy link
Contributor

Covered in #77 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants