Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross train emit zero length files / same files #1217

Closed
daveta opened this issue Apr 26, 2021 · 1 comment
Closed

Cross train emit zero length files / same files #1217

daveta opened this issue Apr 26, 2021 · 1 comment
Assignees
Labels
P0 Must Fix. Release-blocker ShipRoom-Approved Ship room has approved this issue for the release
Milestone

Comments

@daveta
Copy link
Contributor

daveta commented Apr 26, 2021

Versions

What CLI version are you using: 4.13.0

What Nodejs version are you using: 12
What OS are you using: Windows

Describe the bug

bf luis:cross-train --in ./ --out ./generated/interruption --config ./settings/cross-train.config.json --force

Cross-train can emit 0 length files (and generates .qna files and .lu files with the same content).

To Reproduce

bf luis:cross-train --in ./ --out ./generated/interruption --config ./settings/cross-train.config.json --force

Expected behavior

  • Don't generate empty files (at least put byte order mark with comment)
  • Don't emit qna and lu files that are identical.

Might be meaningful to have a "generated by luis:cross-train"
[bug]

@daveta
Copy link
Contributor Author

daveta commented Apr 26, 2021

Closing in favor of Gabo's bugs..

@daveta daveta closed this as completed Apr 26, 2021
@munozemilio munozemilio added this to the R13 milestone Apr 28, 2021
@munozemilio munozemilio added P0 Must Fix. Release-blocker ShipRoom-Approved Ship room has approved this issue for the release labels Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Must Fix. Release-blocker ShipRoom-Approved Ship room has approved this issue for the release
Projects
None yet
Development

No branches or pull requests

3 participants