Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ToDo] ShowToDo error when no ListType #100

Closed
ssss141414 opened this issue Mar 18, 2020 · 0 comments
Closed

[ToDo] ShowToDo error when no ListType #100

ssss141414 opened this issue Mar 18, 2020 · 0 comments
Assignees
Labels
internal This issue was discovered during internal testing P2 Nice to have
Projects

Comments

@ssss141414
Copy link
Contributor

What project is affected?

ToDo skill

What language is this in?

All

What happens?

Some utterance will trigger ShowToDo, but no ListType entity:
Remind me to review my Planner tasks.
Display task notes.
These will cause an error.

Because there are default ListType setting code in Mark/ Delete dialog:
state.ListType = state.ListType ?? ToDoStrings.ToDo;
(Or AskListType step) to avoid this bug. I think ShowToDo should also do this.

What are the steps to reproduce this issue?

What were you expecting to happen?

Can you share any logs, error output, etc.?

Any screenshots or additional context?

@bobokids bobokids added internal This issue was discovered during internal testing P2 Nice to have Status: Committed and removed Needs Triage labels Mar 19, 2020
@bobokids bobokids added this to Backlog in Skills via automation Mar 19, 2020
@bobokids bobokids added this to the GA milestone Mar 19, 2020
@bobokids bobokids moved this from Backlog to Committed in Skills Mar 19, 2020
@ssss141414 ssss141414 mentioned this issue Mar 19, 2020
3 tasks
Skills automation moved this from Committed to Done Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal This issue was discovered during internal testing P2 Nice to have
Projects
No open projects
Skills
  
Done
Development

No branches or pull requests

2 participants