Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar Skill issue with Meeting room booking v8 Release #132

Closed
gagankohli2000 opened this issue Mar 21, 2020 · 2 comments
Closed

Calendar Skill issue with Meeting room booking v8 Release #132

gagankohli2000 opened this issue Mar 21, 2020 · 2 comments
Assignees
Labels
P2 Nice to have
Projects

Comments

@gagankohli2000
Copy link

What project is affected?

Calendar Skill - Meeting room booking solutions

What language is this in?

c#

What happens?

FindMeetingRoomDialog.cs has few issues

Issue 1
Where are you setting state.MeetingInfo.MeetingRoomName?
As this value is null which result is error in GetMeetingRoom()
var state = await Accessor.GetAsync(sc.Context);

            state.MeetingInfo.UnconfirmedMeetingRoom = !string.IsNullOrEmpty(state.MeetingInfo.MeetingRoomName) ?
                    await SearchService.GetMeetingRoomAsync(state.MeetingInfo.MeetingRoomName) :
                    await SearchService.GetMeetingRoomAsync(state.MeetingInfo.Building, state.MeetingInfo.FloorNumber.GetValueOrDefault());

Issue 2
Floor number is hard coded to meetingRooms[0].FloorNumber;

if (state.MeetingInfo.FloorNumber == null)
{
state.MeetingInfo.FloorNumber = meetingRooms[0].FloorNumber;
state.MeetingInfo.MeetingRoomName = meetingRooms[0].DisplayName;
foreach (var room in meetingRooms)
{
if (room.FloorNumber != state.MeetingInfo.FloorNumber)
{
state.MeetingInfo.FloorNumber = null;
break;
}
}
}

What are the steps to reproduce this issue?

What were you expecting to happen?

Can you share any logs, error output, etc.?

Any screenshots or additional context?

@xhr0804 xhr0804 transferred this issue from microsoft/botframework-solutions Mar 23, 2020
@xhr0804 xhr0804 self-assigned this Mar 23, 2020
@xhr0804
Copy link
Contributor

xhr0804 commented Mar 23, 2020

For the issue1, the MeetingRoomName will only be set at the beginning of a dialog. For example "book the meeting room bjw 64", the "bjw 64" will be recognized as MeetingRoomName.
For the issue2, the logic is to check whether there is only one FloorNumber. If there is only one floor, we just use that floorNumber directly, or we will set it to Null and prompt to user.

@bobokids bobokids added this to Backlog in Skills via automation Mar 23, 2020
@bobokids bobokids added this to the GA milestone Mar 23, 2020
@bobokids
Copy link
Contributor

Close the issue for now. @gagankohli2000, if you have more questions/suggestions, please re-activate the issue.

Skills automation moved this from Backlog to Done Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Nice to have
Projects
No open projects
Skills
  
Done
Development

No branches or pull requests

3 participants