Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .tt files in Skills for responses #52

Closed
lauren-mills opened this issue Mar 11, 2020 · 5 comments
Closed

Remove .tt files in Skills for responses #52

lauren-mills opened this issue Mar 11, 2020 · 5 comments
Assignees
Labels
P2 Nice to have
Projects

Comments

@lauren-mills
Copy link
Contributor

What project is affected?

All skills

What language is this in?

C#

What happens?

The .tt files in the skills should be removed to align with the SDK team's LG approach.

@lauren-mills lauren-mills added this to Backlog in Skills via automation Mar 11, 2020
@xieofxie
Copy link
Contributor

Hi @lauren-mills currently for lg, we use tt file to extract names from lg files and then use these constant variables in code with auto-suggestion support instead of copy-paste everywhere. Should we keep it?

@lauren-mills
Copy link
Contributor Author

We should remove it. If we want this sort of functionality for LG we should raise a request on the botbuilder repo instead. The reason for removing it is to reduce the number of unique concepts a developer needs to learn to work with our projects.

@xieofxie
Copy link
Contributor

OK

@DingmaomaoBJTU
Copy link

An issue had been created for this: microsoft/botbuilder-tools#1235

@xieofxie xieofxie mentioned this issue Mar 18, 2020
3 tasks
@bobokids bobokids added P2 Nice to have Status: Committed and removed Needs Triage labels Mar 19, 2020
@bobokids bobokids added this to the GA milestone Mar 19, 2020
@bobokids bobokids moved this from Backlog to Committed in Skills Mar 19, 2020
@bobokids bobokids moved this from Committed to In progress in Skills Mar 19, 2020
@bobokids
Copy link
Contributor

Closed

Skills automation moved this from In progress to Done Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Nice to have
Projects
No open projects
Skills
  
Done
Development

No branches or pull requests

4 participants