Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to reference conversationId property #48

Closed
harshithkashyap opened this issue Oct 25, 2017 · 4 comments
Closed

Allow users to reference conversationId property #48

harshithkashyap opened this issue Oct 25, 2017 · 4 comments
Labels
approved Reviewed and ready to start working on it. Will be added to the work queue in the current iteration. P0 Must Fix. Release-blocker triaged Reviewed by the Triage Team

Comments

@harshithkashyap
Copy link

conversationId property is currently set to private here. Users cannot reconnect to an existing conversation or handle ConnectionStatus.ExpiredToken state.

Change the access modifier to public to allow users to store conversationId externally in a db/localstorage.

This can be overcome by starting the conversation ourselves on the backend and passing streamUrl, token and conversationId to Directline constructor, but as of this code, the refreshToken loop will not be run by directline and users have to manually handle it.
@billba
Copy link
Member

billba commented Oct 25, 2017

That sounds right. Care to file a PR?

@harshithkashyap harshithkashyap mentioned this issue Oct 25, 2017
Closed
@harshithkashyap
Copy link
Author

Gladly :)

@compulim compulim added P0 Must Fix. Release-blocker triaged Reviewed by the Triage Team 4.3 approved Reviewed and ready to start working on it. Will be added to the work queue in the current iteration. labels Dec 14, 2018
@compulim
Copy link
Collaborator

We are tracking the resume story at #124, which will fix this issue.

@compulim compulim added 4.4 and removed 4.3 labels Feb 16, 2019
@cwhitten cwhitten removed the 4.4 label Apr 4, 2019
@cwhitten
Copy link
Member

See #124 for updates on this workstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved Reviewed and ready to start working on it. Will be added to the work queue in the current iteration. P0 Must Fix. Release-blocker triaged Reviewed by the Triage Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change conversationId to public access modifier harshithkashyap/BotFramework-DirectLineJS
5 participants
@cwhitten @compulim @harshithkashyap @jameslew @billba