Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Emulator not sending recipient info #17

Closed
JPThorne opened this issue Nov 23, 2016 · 1 comment
Closed

New Emulator not sending recipient info #17

JPThorne opened this issue Nov 23, 2016 · 1 comment
Assignees
Labels
Bug Your classic code defect

Comments

@JPThorne
Copy link

JPThorne commented Nov 23, 2016

Version 3.5.20 message structure:

from 'user':

{
  "type": "message",
  "text": "hi",
  "from": {
    "id": "default-user",
    "name": "User"
  },
  "timestamp": "2016-11-23T05:35:19.425Z",
  "channelData": {
    "clientActivityId": "1479879313312.7115656006164095.0"
  },
  "serviceUrl": "https://b7eb894d.ngrok.io",
  "id": "511ggghn8i2kann73",
  "channelId": "emulator",
  "recipient": {
    "id": "l3iemcdml1ghd784l"
  },
  "conversation": {
    "id": "b9c9mgcl0jacihcjgc"
  }
}

reply from 'bot':

{
  "type": "message",
  "timestamp": "2016-11-23T05:35:25.570Z",
  "serviceUrl": "https://b7eb894d.ngrok.io",
  "channelId": "emulator",
  "from": {
    "id": "l3iemcdml1ghd784l",
    "name": "Bot"
  },
  "conversation": {
    "id": "b9c9mgcl0jacihcjgc"
  },
  "recipient": {
    "id": ""
  },
  "text": "Please note that by using this chat bot you are agreeing to our terms and conditions. [Ts&Cs](https://nedgroupinvestments.co.za/terms-and-conditions)",
  "attachments": [],
  "entities": [],
  "replyToId": "511ggghn8i2kann73",
  "id": "1nljk346n041j88l4c"
}

compared with version 3.0.0.59:

from 'user':

{
  "type": "message",
  "id": "29a999a3b2e84bb8b84193141f6e2923",
  "timestamp": "2016-11-23T05:37:42.9156081Z",
  "serviceUrl": "http://localhost:9000/",
  "channelId": "emulator",
  "from": {
    "id": "2c1c7fa3",
    "name": "User1"
  },
  "conversation": {
    "isGroup": false,
    "id": "8a684db8",
    "name": "Conv1"
  },
  "recipient": {
    "id": "56800324",
    "name": "Bot1"
  },
  "text": "heyy",
  "attachments": [],
  "entities": []
}

from 'bot':

{
  "type": "message",
  "timestamp": "2016-11-23T05:37:48.1789651Z",
  "serviceUrl": "http://localhost:9000/",
  "channelId": "emulator",
  "from": {
    "id": "56800324",
    "name": "Bot1"
  },
  "conversation": {
    "isGroup": false,
    "id": "8a684db8",
    "name": "Conv1"
  },
  "recipient": {
    "id": "2c1c7fa3",
    "name": "User1"
  },
  "text": "Please note that by using this chat bot you are agreeing to our terms and conditions. [Ts&Cs](https://nedgroupinvestments.co.za/terms-and-conditions)",
  "attachments": [],
  "entities": [],
  "replyToId": "29a999a3b2e84bb8b84193141f6e2923"
}

Spot the difference right? There's no recipient name anymore?

@eanders-ms eanders-ms self-assigned this Nov 23, 2016
@eanders-ms eanders-ms added the Bug Your classic code defect label Nov 23, 2016
@eanders-ms
Copy link
Contributor

@JPThorne We've made an interim fix for this and now send the recipient's id. A more complete fix will be made soon, which will enable sending of name and id of recipients. A new emulator build should be going out later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Your classic code defect
Projects
None yet
Development

No branches or pull requests

2 participants