Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCR] Add proxy support to the sdk #5469

Closed
10 tasks
EricDahlvang opened this issue Jul 18, 2019 · 3 comments
Closed
10 tasks

[DCR] Add proxy support to the sdk #5469

EricDahlvang opened this issue Jul 18, 2019 · 3 comments

Comments

@EricDahlvang
Copy link
Member

EricDahlvang commented Jul 18, 2019

Issue

Some bots are hosted in environments where a proxy is required or preferred. While developers can specify a proxy for their own specific external calls, the framework itself also needs to be able to utilize a proxy server so that all requests, including connector services, qna maker, luis, authentication (openid metadata, etc) will be routed to the proxy server.

The solution should be similar across sdk languages and easy to configure, with all external calls should automatically use the proxy.

Tracking Status

Dotnet SDK
Add proxy support
microsoft/botbuilder-dotnet#2281

  • PR
  • Merged

Javascript SDK
[Botframework-Connector] Proxy Settings are Ignored
microsoft/botbuilder-js#717

  • PR
  • Merged

Java SDK
Add proxy support
microsoft/botbuilder-java#81

  • PR
  • Merged

Python SDK
Add Proxy support
microsoft/botbuilder-python#263

  • PR
  • Merged

Docs
Add docs explaining how to use a proxy with each of the sdk languages.

  • PR
  • Merged

[dcr]

@dmvtech
Copy link
Collaborator

dmvtech commented Aug 15, 2019

Regarding .NET:

Looks like this will be available in .NET core 3.0 in one single spot (similar to how we can do it in .NET Framework currently).

More info:
https://stackoverflow.com/questions/42637592/asp-net-core-defaultproxy

I think it best if we can just use proxy settings at the application level, so that we don't have to manage it otherwise. I don't know whether it's worth it to wait for 3.0 for .NET core, but it definitely would be worthwhile to ensure any httpClient/similar objects inside the SDK would use the 'globally' assigned proxies from the application level.

@cleemullins
Copy link
Contributor

Unless I mis-remember, the current C# SDK (4.5.X) supports a Proxy Server.

@EricDahlvang
Copy link
Member Author

It is possible to use a proxy with 4.5.x, but the support for it could be simplified. Maybe app settings based, rather than the current code changes required. Also, the dotnet sdk could be using HttpClientFactory with named httpclients for the places we are currently creating httpclients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants