Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SkillHandler doesn't return ResourceResponse when forwarding activities #5919

Closed
6 tasks done
Stevenic opened this issue Jun 11, 2020 · 1 comment
Closed
6 tasks done

SkillHandler doesn't return ResourceResponse when forwarding activities #5919

Stevenic opened this issue Jun 11, 2020 · 1 comment
Assignees
@gabog
Labels
BF Customer Ask "Convenience" asks made by our customers and don’t accrue to any major feature P1 Painful if we don't fix, won't block releasing
Projects
Bot Framework SDK - Skills Bot Framework SDK - BF Customer Ask
Milestone
R10 BF Customer Asks

Comments

@Stevenic
Copy link
Contributor

Stevenic commented Jun 11, 2020 •
edited by gabog

Version

4.9

Describe the bug

The SkillHandler currently generates a fake ResourceResponse when it forwards activities from the skill to the channel. This means that future operations like Update and Delete won't work. We instead should remember the response from the call to SendActivityAsync() and return that to the caller. It would be better to send an ResourceResponse without an ID then one that isn't actually actionable.

Tracking Status

Dotnet SDK issue

  • PR
  • Merged

Javascript SDK issue

  • PR
  • Merged

Python SDK issue

  • PR
  • Merged

[bug]
@stevengum stevengum transferred this issue from microsoft/botbuilder-dotnet Jun 15, 2020
@stevengum stevengum added this to To Be Groomed in Bot Framework SDK - Skills via automation Jun 15, 2020
@clearab clearab moved this from To Be Groomed to Feature Rollups in Bot Framework SDK - Skills Jun 15, 2020
@clearab clearab added P1 Painful if we don't fix, won't block releasing R10 Shipping 2020-08-17 and removed R10 Shipping 2020-08-17 labels Jun 15, 2020
This was referenced Jun 15, 2020
Closed
Closed
Closed
@Batta32 Batta32 mentioned this issue Jun 18, 2020
Closed
@clearab clearab added the BF Customer Ask "Convenience" asks made by our customers and don’t accrue to any major feature label Jun 22, 2020
@gabog gabog added this to To Be Groomed in Bot Framework SDK - BF Customer Ask Jun 23, 2020
@gabog gabog added this to the R10 BF Customer Asks milestone Jun 24, 2020
@gabog gabog moved this from To Be Groomed to R10 Feature Rollups in Bot Framework SDK - BF Customer Ask Jun 24, 2020
@gabog gabog self-assigned this Jun 24, 2020
@gabog
Copy link
Contributor

gabog commented Jul 13, 2020

This fix has been implemented on all three languages, closing

@gabog gabog closed this as completed Jul 13, 2020
Bot Framework SDK - Skills automation moved this from Feature Rollups to Done Jul 13, 2020
Bot Framework SDK - BF Customer Ask automation moved this from R10 Feature Rollups to Done Jul 13, 2020
@ekmixon ekmixon mentioned this issue Oct 28, 2023
Open
@amymariaparker2401 amymariaparker2401 mentioned this issue Oct 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabog gabog

Labels
BF Customer Ask "Convenience" asks made by our customers and don’t accrue to any major feature P1 Painful if we don't fix, won't block releasing
Projects
No open projects
Bot Framework SDK - BF Customer Ask
  
R10 Done
Bot Framework SDK - Skills
  
Closed
Milestone
R10 BF Customer Asks
Development

No branches or pull requests
4 participants
@Stevenic @clearab @gabog @stevengum