Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action.execute (AC 1.4) support #6182

Open
10 tasks done
clearab opened this issue Feb 3, 2021 · 8 comments
Open
10 tasks done

Action.execute (AC 1.4) support #6182

clearab opened this issue Feb 3, 2021 · 8 comments
Assignees

Comments

@clearab
Copy link
Contributor

clearab commented Feb 3, 2021

Add support for the Action.Execute command and various flows, including the action/execute invoke and auth flows in both the activity handler and adaptive triggers.

OBI spec is here: https://github.com/microsoft/botframework-obi/pull/128

Hacked up webchat that can do AC 1.4 cards: https://github.com/clearab/CateringDemo

Tracking Status

Dotnet SDK Issue

  • PR
  • Merged

Javascript SDK Issue

  • PR
  • Merged

Python SDK Issue

  • PR
  • Merged

Java SDK Issue

  • PR
  • Merged

**Docs

  • PR
  • Merged
@clearab
Copy link
Contributor Author

clearab commented Jun 4, 2021

@mdrichardson
Copy link
Contributor

@JonathanFingold We're merged in all SDKs for this one. Do you need to do anything with Docs for this?

@clearab clearab closed this as completed Jun 15, 2021
@JonathanFingold
Copy link
Contributor

JonathanFingold commented Jun 15, 2021

@mdrichardson @clearab - I'll need a recommended approach to building bots that support this feature, and actionable messages in particular, for both SDK-first bots and Composer bots. (Adding @kaerm )

  • On the SDK side, it would seems like an activity handler bot without dialogs would make sense, at least for less complicated bots.
  • On the Composer side, I'm guessing custom middleware or a custom channel/connection would make sense, but would not be easy.

@JonathanFingold
Copy link
Contributor

PS. Will the protocol doc get copied to the botframework-sdk repo and be public?

@clearab clearab reopened this Jun 15, 2021
@clearab
Copy link
Contributor Author

clearab commented Jun 15, 2021

I'm going to create some work items for creating (porting really) a sample, as well as documenting. Its in a bit of an odd space, as lots of our partners are documenting this for channel-specific implementations.

@clearab
Copy link
Contributor Author

clearab commented Jun 15, 2021

I'll leave this open though, and associate those new items back.

@clearab clearab self-assigned this Jun 15, 2021
@mdrichardson
Copy link
Contributor

mdrichardson commented Jun 17, 2021

@clearab I just noticed that none of the merged PRs for this add triggers for Adaptive, at least as far as I can tell. I came into this one after just about everything was already merged--can you verify that:

1) We want adaptive triggers for this, and
2) If we do, we don't already have them

I feel like this issue is much bigger than I originally understood (adaptive triggers, auth) and could use a second set of eyes to verify where this one is actually at

@mdrichardson
Copy link
Contributor

@clearab Disregard last. I found it in Components/AdaptiveCards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants