Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

[Skills] use TeamsActivityHandler #3107

Closed
xieofxie opened this issue Feb 25, 2020 · 5 comments
Closed

[Skills] use TeamsActivityHandler #3107

xieofxie opened this issue Feb 25, 2020 · 5 comments
Assignees
Labels
Needs Triage Needs to be triaged for assignment Type: Bug Something isn't working

Comments

@xieofxie
Copy link
Contributor

What project is affected?

skills

What language is this in?

C#

What happens?

Should use TeamsActivityHandler for sign in

What are the steps to reproduce this issue?

Sign in Calendar skill directly in Teams

What were you expecting to happen?

Sign in successfully

Can you share any logs, error output, etc.?

Any screenshots or additional context?

@xieofxie xieofxie added Type: Bug Something isn't working Needs Triage Needs to be triaged for assignment labels Feb 25, 2020
@xieofxie xieofxie closed this as completed Mar 2, 2020
@xieofxie xieofxie reopened this Mar 2, 2020
@xieofxie
Copy link
Contributor Author

xieofxie commented Mar 2, 2020

Also update template? Wonder if it is common to use skill directly in Teams

@bobokids
Copy link
Contributor

bobokids commented Mar 3, 2020

@darrenj , should we use TeamsActivityhandler in skill template? VA template already used it. if we decide to use it we will change all skills accordingly.

@darrenj
Copy link
Contributor

darrenj commented Mar 6, 2020

Adding a Skill to Teams directly wouldn't be something I'd normally expect users to do. I don't see any downside of adding it apart from unnecessary complexity/confusion. Perhaps we add a known issue instead?

@xieofxie
Copy link
Contributor Author

xieofxie commented Mar 6, 2020

@darrenj I would like to add it to skill just as VA. Since they are all bots and we should(?) keep as less as difference as possible

@darrenj
Copy link
Contributor

darrenj commented Mar 13, 2020

I'll discuss with the team!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs Triage Needs to be triaged for assignment Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants