Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle duplicated Location keys #219

Conversation

juzuluag
Copy link
Contributor

@juzuluag juzuluag commented Dec 14, 2022

Issue Number: (214)

Close microsoft#214

Summary

Handle scenarios where location files with the same NamedGeoposition key can be overwritten by another file.

Changes

  • Rename dup keys to allow to be all loaded, avoiding name collision and user missing Geoposition instances.
  • For instance:
    • If a there is a Geoposition eastus on file1.json and in file2.json, loading both files, it would ensure that both Geopositions are loaded. eastus on file2.json can be indexed as eastus_1. User could now retrieve that instance using eastus_1 instead of not be able to find it (current behavior). If there is another one, on a 3rd file, it would be eastus_2 and so on.

Checklist

  • Local Tests Passing?
  • CICD and Pipeline Tests Passing?
  • Added any new Tests?

@juzuluag juzuluag closed this Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve location files handler when dealing with duplicated keys.
1 participant