Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add box-drawing and block element glyphs #11

Closed
DHowett-MSFT opened this issue Aug 18, 2019 · 8 comments · Fixed by #131
Closed

Add box-drawing and block element glyphs #11

DHowett-MSFT opened this issue Aug 18, 2019 · 8 comments · Fixed by #131

Comments

@DHowett-MSFT
Copy link

The entire range of box drawing (U+2500 - U+257F) and block element (U+2580 - U+259F) characters is not covered by the font.

@grantcarthew
Copy link

grantcarthew commented Sep 26, 2019

I just used my Node.js package console-probe and the tree structure is a mess. This is required to support many console tools.

Prior to Cascadia Code:

console-probe

With Cascadia Code:

Capture

I am starting to like this font though. Great work.

@ExE-Boss
Copy link

Same thing occurs with pnpm list ‑‑depth <number> and pnpm why <pkg>.

@mdtauk
Copy link

mdtauk commented Sep 28, 2019

Here are Box Drawing glyphs which can be added to the font - I have exported just those glyphs as a PS OpenType, so it should be trivial to add them in @aaronbell @cinnamon-msft @bitcrazed

  • Vertical Strokes are 180 units wide
  • Horizontal Strokes are 176 units wide.
  • There are -20 / +20 offshoots to avoid gaps between those glyphs which are designed to connect

image

CascadiaCode - Box Drawing.zip link removed, corrected below

@DHowett-MSFT
Copy link
Author

@mdtauk U+2526 looks a little upset:

image

@mdtauk
Copy link

mdtauk commented Sep 28, 2019

@DHowett-MSFT @aaronbell Thanks for the catch - it happened during export to OTF. I corrected the curves so the overlap of the glyph shapes exports correctly.
image

CascadiaCode - Box Drawing.zip

@aaronbell
Copy link
Collaborator

aaronbell commented Sep 29, 2019

@mdtauk Thanks for your help! These look pretty easy to integrate :).

A couple of things:

  1. It looks like the vertical overlaps aren't quite working. I think part of the challenge is that interpretation of vertical metrics can vary from app to app, so it is better to base the height off of the winAscender and winDescender values.

  2. I'm noting that there's a number of other box drawing characters that appear to be missing from the set (mostly the block set).

In all this, though, I happened to remember that Adobe kindly released a script to generate all of these box drawing characters (including blocks) based on user-defined settings. Handy!

@mdtauk
Copy link

mdtauk commented Sep 29, 2019

@aaronbell I used the DejaVuSansMono font as a guide for the overshoots. It seems to be considered a de-facto standard, and I was testing in the preview pane within FontLab. Any adjustments that you need to make is fine.

I was following the Unicode specs.

Box Drawing - https://www.unicode.org/charts/PDF/U2500.pdf
Block Elements - https://www.unicode.org/charts/PDF/U2580.pdf

There may also be scope to include additional glyphs according to a reference site here


I just got done doing the Block Elements glyphs

image

CascadiaCode - Block Elements.zip

@aaronbell
Copy link
Collaborator

Thanks @mdtauk!

Yeah, I tested it in Sublime Text and a couple other places. No problem, I can sort it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants