Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design data reporting APIs #85

Closed
4 tasks done
ross-p-smith opened this issue Dec 7, 2022 · 2 comments
Closed
4 tasks done

Design data reporting APIs #85

ross-p-smith opened this issue Dec 7, 2022 · 2 comments
Assignees

Comments

@ross-p-smith
Copy link
Contributor

ross-p-smith commented Dec 7, 2022

Design Data Reporting - API, Service & Repository Layers.

Requirements: https://github.com/microsoft/ccf-app-samples/blob/main/data-reconciliation-app/docs/data-schema-data-flow.md#data-reporting

Members will query for report summary. All data returned will be JSON. Voting Threshold should be configurable.

Design APIs:

  • by individual record (unique ID)
  • for ALL data

Design Service Layer

Repository Layer:

  • Query K-V store by ID
  • Query K-V store for ALL

Acceptance Criteria:

  1. ADR
  2. Review ADR with team (Sync or Async)
@mkcomer mkcomer changed the title Design API contract for data reporting Design data reporting APIs Dec 14, 2022
@ross-p-smith ross-p-smith self-assigned this Dec 14, 2022
@macromania
Copy link
Contributor

All the api design and service layer connections are implemented on this branch: https://github.com/microsoft/ccf-app-samples/commits/canga/85-data-reporting-api

Remaining work is to

  1. implement this ADR: https://github.com/microsoft/ccf-app-samples/blob/main/data-reconciliation-app/docs/adr/03-reconciliation-logic.md
  2. Unit testing the domain model
  3. Updating demo scripts to have e2e integration testing using curl

@macromania
Copy link
Contributor

I'm closing this issue and remaining work will be tracked on #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants