Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong default value for RUNTIME in package-webapi.sh #544

Closed
Rsimk opened this issue Oct 26, 2023 · 6 comments · Fixed by #606
Closed

Wrong default value for RUNTIME in package-webapi.sh #544

Rsimk opened this issue Oct 26, 2023 · 6 comments · Fixed by #606
Assignees
Labels
deployment Issues related to deploying Chat-Copilot needs input

Comments

@Rsimk
Copy link

Rsimk commented Oct 26, 2023

Describe the bug
webapi package script has default value for RUNTIME set to "linux-x86", but webapi is Windows application. App packaging and app deployment scripts work without error, but webapp would fail with no indications about wrong runtime. Only changing RUNTIME to "win-x64" solves the problem.

To Reproduce
Steps to reproduce the behavior:

  1. run ./package.sh in WSL
  2. run ./deploy.sh
  3. open webapi web app.
  4. pages opens with error ""Server Error in '/' Application."

Expected behavior
webapi URL should open copilot start page.

Screenshots
image

Platform

  • OS: [WSL]
  • IDE: [VS Code]
@crickman crickman added the deployment Issues related to deploying Chat-Copilot label Oct 26, 2023
@crickman crickman assigned crickman and unassigned TaoChenOSU and alliscode Nov 8, 2023
@crickman
Copy link
Contributor

crickman commented Nov 8, 2023

Hi @Rsimk, until recently the deployed version of the API didn't have a start page (other than /healthz). Now that the react app is no longer deployed as a static web app it, the start page should render (if deployed).

Can you confirm that you have deployed the webapp from a recent version of the repo?

@Rsimk
Copy link
Author

Rsimk commented Nov 8, 2023

Hi @Rsimk, until recently the deployed version of the API didn't have a start page (other than /healthz). Now that the react app is no longer deployed as a static web app it, the start page should render (if deployed).

Can you confirm that you have deployed the webapp from a recent version of the repo?

webapp was deployed from Oct 23, commit e139555.

@crickman
Copy link
Contributor

crickman commented Nov 9, 2023

  1. Are you able to access the /heathz route?
  2. Is the webapp / frontend deployed (static pages)?

@Rsimk
Copy link
Author

Rsimk commented Nov 11, 2023

I assume you where asking about "healthz", not "heathz". /healthz return 404.
webapp/webapi is deployed from script. Return code was 202. In Deployment center logs - "Deployment successful.". Looking in file system. Files are actually there.
I redeployed from scratch and now website main page responses with simple text message ""Memory pipeline is running. Uptime: 907 secs."". Although I haven't packaged or deployed it. /healthz still doesn't work.

I change parameter, packaged, deployed and all started working. Including /healthz.
Some interesting observation. If webapi/webapp is packaged with default RUNTIME, file CopilotChatWebApi.exe is not even copied to C:\home\site\wwwroot. As soon as runtime is changed in the script source this file is added to the zip. I guess runtime must be Windows even in the linux script.

@crickman
Copy link
Contributor

Thank you for the follow-up. (Yes: healthz, apologies)

@crickman crickman assigned glahaye and unassigned crickman Nov 13, 2023
@glahaye glahaye linked a pull request Nov 13, 2023 that will close this issue
4 tasks
@glahaye
Copy link
Collaborator

glahaye commented Nov 13, 2023

@Rsimk Yes, you are right. I changed the default to win-x64 in the following PR: #606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Issues related to deploying Chat-Copilot needs input
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants