Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate unnecesssary _Dynamic_bounds_casts #6

Open
dtarditi opened this issue Jan 9, 2019 · 1 comment
Open

Eliminate unnecesssary _Dynamic_bounds_casts #6

dtarditi opened this issue Jan 9, 2019 · 1 comment

Comments

@dtarditi
Copy link
Contributor

dtarditi commented Jan 9, 2019

This is related to #3: there are a number of places where a dynamic bounds cast have been inserted to suppress compiler warning messages. A number of them were because the compiler gives warnings when strings with declared bounds are passed to arguments with default bounds of count(0). We should eliminate these once the compiler is smarter.

@dtarditi dtarditi changed the title Eliminate unnecesssary _Dynamic_bounds_cast Eliminate unnecesssary _Dynamic_bounds_casts Jan 9, 2019
@ppashakhanloo
Copy link

After addressing 0 <= any unsigned integer, the following _Dynamic_bounds_casts can be removed since the compiler can prove them:
lines 515, 670, 673, 285, 527, 1589, 1650, 320, 437, 437, 468, and 469.

Moreover, in line 469, the first argument is actually wrong and should be changed to _Ptr<JSON_Value>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants