4.1.0 has no d.ts files

[pjc0247]

https://www.npmjs.com/package/code-push?activeTab=explore

4.0.5 works fine.

[microsoft-github-policy-service]

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

[microsoft-github-policy-service]

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

[pjc0247]

a

[saurav0705]

any update on this?

[saurav0705]

Please find the pr for the above issue #827

[regalstreak]

bumping ^ @DmitriyKirakosyan

[DmitriyKirakosyan]

@regalstreak , @saurav0705 , @pjc0247 ,

I tried to find the problem with d.ts files not being created using Node 12 and 16, but everything worked fine for me.

Can you tell me exactly what steps you took? This will help me understand the issue better.

Also, I looked at versions 4.0.5 and 4.1.0 and didn't see any big changes that could cause this problem. If you noticed something, please share.

[regalstreak]

@DmitriyKirakosyan try creating a new typescript project and adding the latest version of code-push, the package misses the declarations (checked in node_modules)

4.0.5 also didn't have the d.ts for me

[saurav0705]

@DmitriyKirakosyan the issue the release is pushed with the npm run build command due to which no .d.ts files are generated and package is published with that command

I have raised a pr solving this issue for future can you please check #828

[velimir-jankovic]

@saurav0705 thank you for the help! We've fixed our internal release process, so next release will include definition files properly.

[victor-chan-groundswell]

I'm actually running into this right now, going from 4.0.5 to 4.2.0..... I double checked what's in the node_modules directory and the .d.ts files are definitely missing in the new version. I am using node 21.

With 4.05 after running yarn install...

With 4.20 (on a different branch) after running yarn install....

Seeing that the code is merged in Nov but the latest release is in August 2023... when should there be an ETA on this? We'd like to upgrade so that it gets rid of the vm2 dependency.

[DmitriyKirakosyan]

hi @victor-chan-groundswell , We are planning to release a new version today. There will be another vulnerability fix included.