Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerShell - feedback for README #29

Closed
Vivihung opened this issue Mar 28, 2022 · 0 comments · Fixed by #38
Closed

PowerShell - feedback for README #29

Vivihung opened this issue Mar 28, 2022 · 0 comments · Fixed by #38
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Vivihung
Copy link
Member

Vivihung commented Mar 28, 2022

Here are my feedback for README.md:

  1. Step 2: Add instructions in notepad $profile step - notepad will prompt you to create a profile if not finding one.
  2. Step 3: Add hyperlink to powershell_plugin.ps1
  3. Step 4: Replace python script with codex_query.py
  4. Step 5: I don't think the execution policy should be set to the current user. It's not secure in general. Can we use Process instead of CurrentUser? If we do need CurrentUser, then please consider adding instructions to remove the Policy afterward - refer to https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_execution_policies?view=powershell-7.2#remove-the-execution-policy
    image
  5. We should list having Python registered in PATH as a prerequisite for PowerShell users.
@Vivihung Vivihung added the documentation Improvements or additions to documentation label Mar 28, 2022
@Vivihung Vivihung self-assigned this Mar 30, 2022
@Vivihung Vivihung linked a pull request Mar 31, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant