Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoE Starter Kit - BUG] Comments control not visible in the Video Hub app even comments is enabled #3691

Closed
petepuu opened this issue Sep 16, 2022 · 4 comments
Assignees
Labels
bug Something isn't working coe-starter-kit CoE Starter Kit issues

Comments

@petepuu
Copy link

petepuu commented Sep 16, 2022

Describe the issue

After enabling video comments using environment variable the comments control is not visible

image

Reason is that environment variable value "yes" is not converted to boolean

image

Expected Behavior

Comments control visible after setting environment variable to Yes. This can be fixed at least by converting "yes" to 1 using Value() function but maybe better to do the conversion already when environment variable value is fetched in App.Start event

image

What solution are you experiencing the issue with?

Nurture

What solution version are you using?

2.15

What app or flow are you having the issue with?

Video Hub

Steps To Reproduce

No response

Anything else?

No response

@petepuu petepuu added bug Something isn't working coe-starter-kit CoE Starter Kit issues labels Sep 16, 2022
@manuelap-msft
Copy link
Contributor

Thanks for the debugging here, we missed this in our testing! That's an easy fix we'll schedule for our October release.

@petepuu
Copy link
Author

petepuu commented Sep 16, 2022

Thanks @manuelap-msft for very quick response! I noticed probably another issue with comments. There is no submit button in the control or how should the comment be submitted?

image

@Jenefer-Monroe
Copy link
Collaborator

It looks like these all come down to the variable not being converted to bool. I'm fixing up now for Oct.

@CoEStarterKitBot
Copy link
Collaborator

@petepuu This has been fixed in the latest release. Please install the latest version of the toolkit following the instructions for installing updates. Note that if you do not remove the unmanaged layers as described there you will not receive updates from us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working coe-starter-kit CoE Starter Kit issues
Projects
Archived in project
Development

No branches or pull requests

4 participants