Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoE Starter Kit - BUG] Setup Wizard > Compliance Process Flows fail to enable - but notification does not point to which flow failed. #4465

Closed
rrwolfe opened this issue Dec 16, 2022 · 6 comments
Assignees
Labels
bug Something isn't working coe-starter-kit CoE Starter Kit issues

Comments

@rrwolfe
Copy link

rrwolfe commented Dec 16, 2022

Describe the issue

When going through the Compliance Process setup wizard, the flows highlighted in the screenshot below fail to enable unless you have previously defined the Developer Compliance Center URL environment variable. They rely on this variable to be populated or will fail to turn on. Unfortunately, the wizard presents these disabled flows as "On" after click from Off to On, even though they have failed to turn on. Failures do appear at the top of the UI, but do not specify which flows failed requiring investigation.

image

Expected Behavior

Recommend adding automation to pre-populate the Developer Compliance Center Environment URL on load of the Compliance Process wizard, or have a field for the URL to be entered manually prior to the flow enablement screen.

What solution are you experiencing the issue with?

Core

What solution version are you using?

4.2

What app or flow are you having the issue with?

Setup Wizard

Steps To Reproduce

Go through the Compliance Process setup wizard without having defined the Developer Compliance Center URL previously and turn on the flows highlighted below to see the failures:
image

Anything else?

No response

@rrwolfe rrwolfe added bug Something isn't working coe-starter-kit CoE Starter Kit issues labels Dec 16, 2022
@manuelap-msft
Copy link
Contributor

Hello,

the Developer Compliance Center Environment URL is set in the App.OnStart of the Compliance Setup Wizard as at that point we have all the info required to set it automatically behind the scenes. Are you saying this didn't happen in your case? Would you be able to open the app in Monitor mode and see if any errors are happening during the Patch of this URL? Thank you!

@rrwolfe
Copy link
Author

rrwolfe commented Dec 17, 2022

Thank you! Please note that this issue is occurring in a DoD tenant, so this may be a regional nuance. I don't see any errors when running the app in monitoring mode and also no requests related to the developer compliance center URL. I had defined the incorrect graph endpoint (commercial) for the HTTP with Azure AD connection reference. This was causing the Setup Wizard > GetUserDetails flow to fail. I've since updated that connection reference to use the DoD graph endpoint and that flow is now running successfully. I don't think this would be related though as it looks like that's just retrieving the user license information.

@Jenefer-Monroe
Copy link
Collaborator

Aside from why these flows failed to turn on. The other issue here is that there's no notification of what flow failed to turn on.
Is it possible to show which flow failed in the notification?

@manuelap-msft
Copy link
Contributor

Checked the code that automatically sets the variable now and this is related to #4458 where users are not prompted to re-run the solution metadata flow if they import the governance / nurture solution after the perform the initial setup and thus when this page opens the metadata for the developer compliance center URL is not empty.

This will be fixed when we address #4458 with the next release, and I'll leave this issue open to track making the notification flow specific.

@Jenefer-Monroe Jenefer-Monroe changed the title [CoE Starter Kit - BUG] Setup Wizard > Compliance Process Flows fail to enable [CoE Starter Kit - BUG] Setup Wizard > Compliance Process Flows fail to enable - but notification does not point to which flow failed. Dec 20, 2022
@manuelap-msft
Copy link
Contributor

Fixed for February release

Image

@CoEStarterKitBot
Copy link
Collaborator

@rrwolfe This has been fixed in the latest release. Please install the latest version of the toolkit following the instructions for installing updates. Note that if you do not remove the unmanaged layers as described there you will not receive updates from us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working coe-starter-kit CoE Starter Kit issues
Projects
Archived in project
Development

No branches or pull requests

4 participants