Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALM Accelerator - Feature]: Override pool/vmimage used by ALM pipelines #5533

Closed
wiskaso opened this issue May 15, 2023 · 2 comments · Fixed by microsoft/coe-alm-accelerator-templates#314
Assignees
Labels
alm-accelerator ALM Accelerator Components and Apps enhancement New feature or request

Comments

@wiskaso
Copy link

wiskaso commented May 15, 2023

Is your feature request related to a problem? Please describe.

We do not use the Azure Hosted Agents but instead host our own build agents. In order to use our internal agents, we have to update the pool and image names used by the ALM templates directly which causes merge conflicts every time we go to update our ALM templates via the sync repo script.

Describe the solution you'd like

Is it possible to parameterize and/or provide a way to override the pool and vmimage name values without directly editing the file to avoid causing merge conflicts?

Describe alternatives you've considered

Current alternative is to have someone manually resolve merge conflicts.

Additional context?

No response

@wiskaso wiskaso added alm-accelerator ALM Accelerator Components and Apps enhancement New feature or request labels May 15, 2023
@mikefactorial mikefactorial self-assigned this May 16, 2023
@mikefactorial
Copy link
Collaborator

@wiskaso thanks for submitting this. We've had an issue in our backlog for this for a while that we haven't gotten around to updating since we didn't get a lot of feedback that it was a priority. So appreciate you bringing it up #837. Will look into how best to solve this in an upcoming release.

@CoEStarterKitBot
Copy link
Collaborator

@wiskaso This has been fixed in the latest release. Please install the latest version of the toolkit following the instructions for installing updates. Note that if you do not remove the unmanaged layers as described there you will not receive updates from us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alm-accelerator ALM Accelerator Components and Apps enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants